Damn,

Thought I had enough retries to get around these corner cases but here again

3 rounds of centos failures failed faster then virl failure then success so it 
ended up with a +1 that shouldn’t have been the case.

Would not have been the case if the failure was also seen on ubuntu but this is 
still possible when the failure is NOT seen on ubuntu.

But thanks for the new patch…either that or revert the original bad patch is 
certainly the thing to do..

thanks,

Ed



On May 2, 2018, at 9:12 AM, Matthew Smith 
<mgsm...@netgate.com<mailto:mgsm...@netgate.com>> wrote:


I see errors when trying to build from master on CentOS 7:

/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c: In function 
vxlan_rewrite':
/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c:224:3: 
error:missing braces around initializer [-Werror=missing-braces]
   } h = {0};
   ^
/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c:224:3: 
error:(near initialization for 'h.h4') [-Werror=missing-braces]
/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c: In function 
vnet_vxlan_add_del_tunnel':
/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c:388:7: 
error:missing braces around initializer [-Werror=missing-braces]
       *t = (vxlan_tunnel_t){ 0 };
       ^
/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c:388:7: 
error:(near initialization for '(anonymous).next_dpo') [-Werror=missing-braces]
/root/src/tnsr-pkgs/work/vpp/build-data/../src/vnet/vxlan/vxlan.c: At top level:
cc1: error: unrecognized command line option "-Wno-address-of-packed-member" 
[-Werror]
cc1: all warnings being treated as errors
make[4]: *** [vnet/vxlan/vxlan.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory 
`/root/src/tnsr-pkgs/work/vpp/build-root/build-vpp_debug-native/vpp'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory 
`/root/src/tnsr-pkgs/work/vpp/build-root/build-vpp_debug-native/vpp'
make[2]: *** [all] Error 2
make[2]: Leaving directory 
`/root/src/tnsr-pkgs/work/vpp/build-root/build-vpp_debug-native/vpp'
make[1]: *** [vpp-build] Error 2
make[1]: Leaving directory `/root/src/tnsr-pkgs/work/vpp/build-root'
make: *** [build] Error 2


This appears to be broken by https://gerrit.fd.io/r/#/c/12288/. The history 
there shows that the centos7 verify jobs failed with the same errors, but 
somehow the change ended up as Verified+1.

I submitted a patch (https://gerrit.fd.io/r/#/c/12349/) that makes the build 
work again for me. I haven’t tested it extensively, just built with it on 
CentOS 7 and then made sure vpp would start up afterwards.

-Matt



Reply via email to