No, it is not same... removing extern will result in sample_main instance in each object file created from C file which includes this specific header file.
-- Damjan > On 20 Jul 2018, at 18:03, abdul.ma...@sofioni.com wrote: > > I think its the same if we define sample_main variable in sample.c file or if > we remove the key word extern in sample.h. I have tried removing extern and > it works but defining sample_main in .c file should also work. > > > > > On 2018-07-20 19:02, Damjan Marion via Lists.Fd.Io wrote: > >> >> This should be the proper fix for your issue: >> >> https://gerrit.fd.io/r/#/c/13589/ <https://gerrit.fd.io/r/#/c/13589/> >> >> Please confirm... >> >> -- >> Damjan >> >>> On 20 Jul 2018, at 15:52, abdul.ma...@sofioni.com >>> <mailto:abdul.ma...@sofioni.com> wrote: >>> >>> When I ran vpp 18.07 in interactive mode I found that vpp was unable to >>> load sample_plugin due to an error of undefined variable *sample_main* used >>> in sample.c file. However, *sample_main* is defined in sample.h file as >>> follows. >>> >>> extern sample_main_t sample_main; >>> >>> Removing keyword extern worked for me. Now vpp 18.07 successfully loads >>> sample_plugin. >>> >>> >>> >>> >>> On 2018-07-18 18:22, abdul.ma...@sofioni.com >>> <mailto:abdul.ma...@sofioni.com> wrote: >>> >>> Hello All, >>> >>> I am trying to build vpp stable/1807 with sample plugin enabled on ubuntu >>> 16.04.2 using following guide. >>> >>> https://docs.fd.io/vpp/18.07/sample_plugin_doc.html >>> <https://docs.fd.io/vpp/18.07/sample_plugin_doc.html> >>> Build process goes without any error and then I make .deb packages and >>> install these packages on a different host (ubuntu 16.04.2) but when I >>> check vpp plugins using vppctl show plugins command; I see many plugins >>> except sample plugin. I also don't see any sample plugin under >>> /usr/lib/vpp_plugins directory. Should I need to do any additional step. >>> >>> Note: I did the same process for vpp stable/1707 and it went through >>> perfectly fine and I was able to use and test vpp sample plugin. >>> >>> >>> >>> Thanks >>> >>> Regards, >>> >>> Abdul Malik >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> >>> View/Reply Online (#9876): https://lists.fd.io/g/vpp-dev/message/9876 >>> <https://lists.fd.io/g/vpp-dev/message/9876> >>> Mute This Topic: https://lists.fd.io/mt/23670834/1123042 >>> <https://lists.fd.io/mt/23670834/1123042> >>> Group Owner: vpp-dev+ow...@lists.fd.io <mailto:vpp-dev+ow...@lists.fd.io> >>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub >>> <https://lists.fd.io/g/vpp-dev/unsub> [abdul.ma...@sofioni.com >>> <mailto:abdul.ma...@sofioni.com>] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> >>> View/Reply Online (#9898): https://lists.fd.io/g/vpp-dev/message/9898 >>> <https://lists.fd.io/g/vpp-dev/message/9898> >>> Mute This Topic: https://lists.fd.io/mt/23670834/675642 >>> <https://lists.fd.io/mt/23670834/675642> >>> Group Owner: vpp-dev+ow...@lists.fd.io <mailto:vpp-dev+ow...@lists.fd.io> >>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub >>> <https://lists.fd.io/g/vpp-dev/unsub> [dmar...@me.com >>> <mailto:dmar...@me.com>] >>> -=-=-=-=-=-=-=-=-=-=-=- >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> >> View/Reply Online (#9899): https://lists.fd.io/g/vpp-dev/message/9899 >> <https://lists.fd.io/g/vpp-dev/message/9899> >> Mute This Topic: https://lists.fd.io/mt/23670834/1123042 >> <https://lists.fd.io/mt/23670834/1123042> >> Group Owner: vpp-dev+ow...@lists.fd.io <mailto:vpp-dev+ow...@lists.fd.io> >> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub >> <https://lists.fd.io/g/vpp-dev/unsub> [abdul.ma...@sofioni.com >> <mailto:abdul.ma...@sofioni.com>] >> -=-=-=-=-=-=-=-=-=-=-=- > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#9900): https://lists.fd.io/g/vpp-dev/message/9900 > Mute This Topic: https://lists.fd.io/mt/23670834/675642 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9901): https://lists.fd.io/g/vpp-dev/message/9901 Mute This Topic: https://lists.fd.io/mt/23670834/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
