Hi,
I expected it was ‘fixed’ when we explicitly disallowed overlapping subnets:
https://gerrit.fd.io/r/#/c/8057/
/neale
From: <vpp-dev@lists.fd.io> on behalf of "sainijite...@gmail.com"
<sainijite...@gmail.com>
Date: Monday, 23 July 2018 at 12:42
To: "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>
Subject: [vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet
[Edited Message Follows]
Hello,
We are using vpp stable release 1710 and encountered vpp crash in the following
scenario (IP Address addition) -
1. configure ip
2. configure network / broadcast ip explicitly on same interface
Same crash behavior is observed with VPP release 1801 but issue is not seen in
release 1804.
Since issue was fixed between release 1801 & 1804, I wanted to find out which
code change exactly fixes this issue.
Could someone please help to get some starting pointers here.
In summary -
If we have an issue which is fixed in some latest version of the vpp build, how
do we track the changes which fixed the issues?
Crash scenario example and backtrace -
-------------------------------------------------------------------------
create sub EthernetSwitch2/0/0 8
set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <------- valid
address
set interface ip address EthernetSwitch2/0/0 10.10.10.0/24 <------- network
address <<< crash
-------------------------------------------------------------------------
-------------------------------------------------------------------------
create sub EthernetSwitch2/0/0 8
set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <------- valid
address
set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <------- broadcast
address <<< crash
-------------------------------------------------------------------------
-------------------------------------------------------------------------
create sub EthernetSwitch2/0/0 8
set interface ip address EthernetSwitch2/0/0.8 10.10.10.0/24 <------- network
address
set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <------- broadcast
address <<< crash
-------------------------------------------------------------------------
DBGvpp# set interface ip address VirtualFunctionEthernet0/5/0 10.10.10.128/24
DBGvpp# create sub VirtualFunctionEthernet0/5/0 8
VirtualFunctionEthernet0/5/0.8
DBGvpp# set interface ip address VirtualFunctionEthernet0/5/0.8 10.10.10.0/24
0: /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path.c:2085
(fib_path_get_adj) assertion `dpo_is_adj(&path->fp_dpo)' fails
Thread 1 "vpp_main" received signal SIGABRT, Aborted.
0x00007ffff601b428 in __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:54
54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0 0x00007ffff601b428 in __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007ffff601d02a in __GI_abort () at abort.c:89
#2 0x0000000000406a34 in os_panic () at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vpp/vnet/main.c:268
#3 0x00007ffff68018ff in debugger () at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/error.c:84
#4 0x00007ffff6801d07 in _clib_error (how_to_die=2, function_name=0x0,
line_number=0, fmt=0x7ffff754d770 "%s:%d (%s) assertion `%s' fails") at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/error.c:143
#5 0x00007ffff73b18ba in fib_path_get_adj (path_index=12) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path.c:2085
#6 0x00007ffff73ac75a in fib_path_list_get_adj (path_list_index=12,
type=FIB_FORW_CHAIN_TYPE_UNICAST_IP4) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path_list.c:1178
#7 0x00007ffff739edfe in fib_entry_src_interface_path_swap
(src=0x7fffb6393cc4, entry=0x7fffb6aa6e64, pl_flags=FIB_PATH_LIST_FLAG_LOCAL,
paths=0x7fffb62db94c) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry_src_interface.c:69
#8 0x00007ffff739d0cd in fib_entry_src_action_path_swap
(fib_entry=0x7fffb6aa6e64, source=FIB_SOURCE_INTERFACE,
flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), rpaths=0x7fffb62db94c)
at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry_src.c:1205
#9 0x00007ffff7399203 in fib_entry_update (fib_entry_index=8,
source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED |
FIB_ENTRY_FLAG_LOCAL), paths=0x7fffb62db94c) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry.c:1113
#10 0x00007ffff738491c in fib_table_entry_update (fib_index=0,
prefix=0x7fffb62fe770, source=FIB_SOURCE_INTERFACE,
flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), paths=0x7fffb62db94c)
at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_table.c:743
#11 0x00007ffff7384b14 in fib_table_entry_update_one_path (fib_index=0,
prefix=0x7fffb62fe770, source=FIB_SOURCE_INTERFACE,
flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL),
next_hop_proto=DPO_PROTO_IP4, next_hop=0x7fffb62fe774, next_hop_sw_if_index=3,
next_hop_fib_index=4294967295, next_hop_weight=1, next_hop_labels=0x0,
path_flags=FIB_ROUTE_PATH_FLAG_NONE) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_table.c:781
#12 0x00007ffff6d9a7b0 in ip4_add_interface_routes (sw_if_index=3,
im=0x7ffff7880920 <ip4_main>, fib_index=0, a=0x7fffb62e2760) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/ip/ip4_forward.c:808
#13 0x00007ffff6d9b381 in ip4_add_del_interface_address_internal
(vm=0x7ffff7b89480 <vlib_global_main>, sw_if_index=3, address=0x7fffb62fe950,
address_length=24, is_del=0) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/ip/ip4_forward.c:968
#14 0x00007ffff6d9b4fa in ip4_add_del_interface_address (vm=0x7ffff7b89480
<vlib_global_main>, sw_if_index=3, address=0x7fffb62fe950, address_length=24,
is_del=0) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/ip/ip4_forward.c:993
#15 0x00007ffff6d8c7bb in add_del_ip_address (vm=0x7ffff7b89480
<vlib_global_main>, input=0x7fffb62feef0, cmd=0x7fffb638c728) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/ip/ip46_cli.c:169
#16 0x00007ffff78b30d0 in vlib_cli_dispatch_sub_commands (vm=0x7ffff7b89480
<vlib_global_main>, cm=0x7ffff7b89660 <vlib_global_main+480>,
input=0x7fffb62feef0, parent_command_index=170) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/cli.c:588
#17 0x00007ffff78b2fde in vlib_cli_dispatch_sub_commands (vm=0x7ffff7b89480
<vlib_global_main>, cm=0x7ffff7b89660 <vlib_global_main+480>,
input=0x7fffb62feef0, parent_command_index=41) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/cli.c:566
#18 0x00007ffff78b2fde in vlib_cli_dispatch_sub_commands (vm=0x7ffff7b89480
<vlib_global_main>, cm=0x7ffff7b89660 <vlib_global_main+480>,
input=0x7fffb62feef0, parent_command_index=35) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/cli.c:566
#19 0x00007ffff78b2fde in vlib_cli_dispatch_sub_commands (vm=0x7ffff7b89480
<vlib_global_main>, cm=0x7ffff7b89660 <vlib_global_main+480>,
input=0x7fffb62feef0, parent_command_index=0) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/cli.c:566
#20 0x00007ffff78b33b5 in vlib_cli_input (vm=0x7ffff7b89480 <vlib_global_main>,
input=0x7fffb62feef0, function=0x7ffff7942884 <unix_vlib_cli_output>,
function_arg=0) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/cli.c:662
#21 0x00007ffff7948042 in unix_cli_process_input (cm=0x7ffff7b892e0
<unix_cli_main>, cli_file_index=0) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/unix/cli.c:2308
#22 0x00007ffff7948ba0 in unix_cli_process (vm=0x7ffff7b89480
<vlib_global_main>, rt=0x7fffb62ee000, f=0x0) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/unix/cli.c:2420
#23 0x00007ffff78e7520 in vlib_process_bootstrap (_a=140736257780336) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/main.c:1231
#24 0x00007ffff6825dd4 in clib_calljmp () at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/longjmp.S:110
#25 0x00007fffb6a6ea40 in ?? ()
#26 0x00007ffff78e764b in vlib_process_startup (vm=0x7ffff687913e
<vec_aligned_header_bytes+54>, p=0x7fffb6a6ea80, f=0x5a7ec91311e2c800) at
/home/vagrant/jisaini/fdio/vpp/build-data/../src/vlib/main.c:1253
#27 0x0000000000000000 in ?? ()
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9910): https://lists.fd.io/g/vpp-dev/message/9910
Mute This Topic: https://lists.fd.io/mt/23791651/21656
Mute #vnet: https://lists.fd.io/mk?hashtag=vnet&subid=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
