Hi Damjan,

                I’m aware that this issue has been fixed not long ago by the 
following patch.
You can ignore my previous email now.

commit 1e1c0f55dba1adc2ddf78fa39e390f88962f3f7b
Author: Paul Vinciguerra 
<pvi...@vinciconsulting.com<mailto:pvi...@vinciconsulting.com>>
Date:   Sat Nov 24 21:19:38 2018 -0800

    make test: Fix too wide subprocess exceptions

    When a command fails, CalledProcessError is raised. testing with except: 
masks other failures.

    Change-Id: I7e3a6739411cb6a4c13e96dd123aff9159213fea
    Signed-off-by: Paul Vinciguerra 
<pvi...@vinciconsulting.com<mailto:pvi...@vinciconsulting.com>>

This patch includes this change.

@@ -290,7 +290,7 @@ pmalloc_map_pages (clib_pmalloc_main_t * pm, 
clib_pmalloc_arena_t * a,
       return 0;
     }

-  mmap_flags = MAP_FIXED;
+  mmap_flags = MAP_FIXED | MAP_ANONYMOUS;


Thanks
Zhiyong
From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Zhiyong Yang
Sent: Monday, November 26, 2018 3:37 PM
To: Yang, Zhiyong <zhiyong.y...@intel.com>; Damjan Marion <dmar...@me.com>
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] fails to startup vpp on master branch.

Hi Damjan,

This issue is caused by this patch.

54e8e39a5284917efab8fd6d7d92e589d4a911a4 is the first bad commit
commit 54e8e39a5284917efab8fd6d7d92e589d4a911a4
Author: Damjan Marion <damar...@cisco.com<mailto:damar...@cisco.com>>
Date:   Wed Nov 7 17:55:26 2018 +0100

    pmalloc: fix shared mappings

    Change-Id: I6782544d5ee0a66b1a027874b23574416093ca92
Signed-off-by: Damjan Marion damar...@cisco.com<mailto:damar...@cisco.com>


diff --git a/src/vppinfra/pmalloc.c b/src/vppinfra/pmalloc.c
index a881a65..46ccd7f 100644
--- a/src/vppinfra/pmalloc.c
+++ b/src/vppinfra/pmalloc.c
@@ -290,7 +290,7 @@ pmalloc_map_pages (clib_pmalloc_main_t * pm, 
clib_pmalloc_arena_t * a,
       return 0;
     }

-  mmap_flags = MAP_FIXED | MAP_ANONYMOUS;
+  mmap_flags = MAP_FIXED;

   if ((pm->flags & CLIB_PMALLOC_F_NO_PAGEMAP) == 0)
     mmap_flags |= MAP_LOCKED;
@@ -307,10 +307,12 @@ pmalloc_map_pages (clib_pmalloc_main_t * pm, 
clib_pmalloc_arena_t * a,
        pm->error = clib_mem_create_fd ((char *) a->name, &a->fd);
       if (a->fd == -1)
        goto error;
+      if ((ftruncate (a->fd, size)) == -1)
+       goto error;
     }
   else
     {
-      mmap_flags |= MAP_PRIVATE;
+      mmap_flags |= MAP_PRIVATE | MAP_ANONYMOUS;
       a->fd = -1;
     }

I try to restore the first line changed. It works well on CentOS.


Thanks
Zhiyong

From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Zhiyong Yang
Sent: Monday, November 19, 2018 6:11 PM
To: Damjan Marion <dmar...@me.com>
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] fails to startup vpp on master branch.

BOOT_IMAGE=/vmlinuz-3.10.0-862.14.4.el7.x86_64 root=/dev/mapper/centos-root ro 
crashkernel=auto rd.lvm.lv=centos/root rd.lvm.lv=centos/swap rhgb quiet 
default_hugepagesz=1G hugepagesz=1G hugepages=8 intel_iommu=on iommu=pt 
isolcpus=1-20 LANG=en_US.UTF-8 nohz_full=1-20 rcu_nocbs=1-20

From: Damjan Marion [mailto:dmar...@me.com]
Sent: Monday, November 19, 2018 5:59 PM
To: Yang, Zhiyong <zhiyong.y...@intel.com<mailto:zhiyong.y...@intel.com>>
Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] fails to startup vpp on master branch.

kernel parameters?

--
Damjan

On 19 Nov 2018, at 10:57, Yang, Zhiyong 
<zhiyong.y...@intel.com<mailto:zhiyong.y...@intel.com>> wrote:

Damjan,

                I’m working on CentOS 7.5 and on the latest master for VPP.
Uname –r
3.10.0-862.14.4.el7.x86_64

[root@localhost vpp]# cat /etc/redhat-release
CentOS Linux release 7.5.1804 (Core)

Thanks
Zhiyong
From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> 
[mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan Marion via Lists.Fd.Io
Sent: Monday, November 19, 2018 5:42 PM
To: Yang, Zhiyong <zhiyong.y...@intel.com<mailto:zhiyong.y...@intel.com>>
Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] fails to startup vpp on master branch.



Your kernel is refusing to do mmap().
We need a bit more info, kernel version, kernel parameters,

Are you on the latest master?

--
Damjan

On 19 Nov 2018, at 10:25, Zhiyong Yang 
<zhiyong.y...@intel.com<mailto:zhiyong.y...@intel.com>> wrote:

Hi VPP dev guys,

                Does Anybody see the failures about vpp on master branch as 
following?  The failures must be reproduced on my 3 servers/boxes.  How can I 
fix it ?

vlib_physmem_shared_map_create: pmalloc_map_pages: failed to mmap 1 pages at 
0x7fd940000000 fd 25 numa 0 flags 0x42011: Invalid argument

dpdk_buffer_pool_create: failed to allocate mempool on socket 0

Thanks
Zhiyong


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11303): https://lists.fd.io/g/vpp-dev/message/11303
Mute This Topic: https://lists.fd.io/mt/28239923/675642
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[dmar...@me.com<mailto:dmar...@me.com>]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11403): https://lists.fd.io/g/vpp-dev/message/11403
Mute This Topic: https://lists.fd.io/mt/28239923/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to