Hi vpp-dev,

I’m looking at the ip-rewrite node, and I think it might be a bug at:

vnet_rewrite_one_header (adj0[0], ip0, sizeof (ethernet_header_t));

The adj-> rewrite_header.data_bytes might be 0 when it comes to tunnel 
interface, f.g., gtpu, ipsec. Thus, at least 8 bytes garbage are written to 
buffer unexpectedly. I came across to this because I’m doing handoff for tunnel 
interface, and in this case, 8 bytes memcpy leads to some performance loss, 
cache trashing…

Temporarily I created a patch for more discussion. Please take a look. There 
should be a better way to fix it…

https://gerrit.fd.io/r/18014

Regards,
Kingwel
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12431): https://lists.fd.io/g/vpp-dev/message/12431
Mute This Topic: https://lists.fd.io/mt/30224541/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to