Hi Joe, Thank you very much for catching this bug. I took a look at your patch which looks to be the right fix to this problem. Without this fix, I suppose the work around is to always add BVI interface to a BD last, after all other interfaces are added in the BD.
Can you push your patch to fd.io gerrit directly for code review, please? I'll be happy to review your patch and merge to master branch after it is built and passes regression properly. The following URL describes how to push your patch to fd.io gerrit for review: https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing Regards, John From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of "Zhou You(Joe Zhou) Sent: Wednesday, March 06, 2019 10:31 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] subif interface api handle function bug Dear vpp devs: I met a bug while adding 802.1q subif interface into bridge domain via python api. BVI interface must be the first number of bridge domain, but after I added a subif into bd, subif took the first position of bd, and the l2 flooding didn't run well: here is the infomation: vpp# show bridge-domain 10 detail BD-ID Index BSN Age(min) Learning U-Forwrd UU-Flood Flooding ARP-Term BVI-Intf 10 2 0 60 on on flood on off loop10 Interface If-idx ISN SHG BVI TxFlood VLAN-Tag-Rewrite GigabitEthernet2/0/0.10 8 7 0 - * pop-1 loop10 7 8 0 * * none GigabitEthernet1/0/0 1 11 0 - * none I read the code, found vl_api_create_vlan_subif_t_handler and vl_api_create_subif_t_handler function lacking an assignment of :template.flood_class = VNET_FLOOD_CLASS_NORMAL; I think it might be a bug, and create a patch, looking forward the bug to be fixed:-) ---- Best Regards Joe Zhou
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12451): https://lists.fd.io/g/vpp-dev/message/12451 Mute This Topic: https://lists.fd.io/mt/30294062/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
