SemVer says: > Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards > compatible bug fixes are introduced. > A bug fix is defined as an internal change that fixes incorrect behavior.
That means API version should be bumped even if the change only affects the implementation (and not API definition itself). In principle, if there is an internal change which has not fixed any incorrect behavior, SemVer says you are not required to bump the patch version. > multiple version of plugins can provide exact same binary API That could happen when the plugin undergoes such an internal change that does not affect behavior at all (at least not positively). Do you have a realistic example of that? All I can think of is renaming a variable, or similar silly examples. Either way, I think it is safe to assume that any plugin version bump can have at least some behavior consequence visible to user, so bumping API at the same time is simpler. Alternatively, we can change the plugin versioning scheme to acomodate "invisible" bumps. X.Y.Z.W (Major.Minor.Patch.Internal). Vratko. From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Saturday, 2019-May-25 19:46 To: Paul Vinciguerra <pvi...@vinciconsulting.com> Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Plugin Versions On 25 May 2019, at 18:42, Paul Vinciguerra <pvi...@vinciconsulting.com<mailto:pvi...@vinciconsulting.com>> wrote: Sorry. Let me try again. The semver definition seems to say that backend changes that don't change the API, still should have the patch version increased. Bug fixes not affecting the API increment the patch version New features would either be backward compatible with the API or not, therefore incrementing the major, minor, or patch version. That seems to me to make the need for the plugin version to be redundant. Yes? no. as i sad multiple version of plugins can provide exact same binary API so plugin version may be different but binary api version will be the same.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13153): https://lists.fd.io/g/vpp-dev/message/13153 Mute This Topic: https://lists.fd.io/mt/31757481/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
