Hi,
That is correct. You want to provide the patch or should I do it?
Thanks,
Florin
> On Jun 28, 2019, at 6:10 AM, guangwei <caoguangwei...@163.com> wrote:
>
> Now, I'am searching the TCP stack of VPP 19.04, and have a doubt, please look
> following comment in line.
>
> tcp46_rcv_process_inline
> {
> ...
> /* 5: check the ACK field */
> ...
> case TCP_STATE_CLOSE_WAIT:
> /* Do the same processing as for the ESTABLISHED state. */
> if (tcp_rcv_ack (wrk, tc0, b0, tcp0, &error0))
> goto drop;
>
> if (!(tc0->flags & TCP_CONN_FINPNDG))
> break;
>
> /* Still have outstanding tx data */
> if (transport_max_tx_dequeue (&tc0->connection)) <--------Here, I think
> should check burst_acked as TCP_STATE_FIN_WAIT_1 do.
> break;
>
> tcp_send_fin (tc0);
> tcp_connection_timers_reset (tc0);
> tcp_connection_set_state (tc0, TCP_STATE_LAST_ACK);
> tcp_timer_set (tc0, TCP_TIMER_WAITCLOSE, TCP_2MSL_TIME);
> break;
>
> ...
>
> }
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#13393): https://lists.fd.io/g/vpp-dev/message/13393
> Mute This Topic: https://lists.fd.io/mt/32241597/675152
> Mute #vnet: https://lists.fd.io/mk?hashtag=vnet&subid=1480544
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [fcoras.li...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13397): https://lists.fd.io/g/vpp-dev/message/13397
Mute This Topic: https://lists.fd.io/mt/32241597/21656
Mute #vnet: https://lists.fd.io/mk?hashtag=vnet&subid=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
