[vpp-dev] Trouble with checkstyle?

[Jim Thompson via Lists.Fd.Io]

So I’ve got this tiny patch to add a couple QAT PCIe IDs:

But when I run checkstyle.sh, it moans, and wants me to run indent twice.

Here’s the thing, the only thing that’s changed by the indent is the ELOG 
statements.
The little piece I tried to add is unchanged, but checkstyle.sh passes without 
my change to add the PCIe IDs for c4xxx and d15xx QAT.

Is this a bug in checkstyle?

Should I just go ahead and submit the below, or should I attempt to submit just 
the part that adds PCIe IDs for the two missing QAT VFs?

Jim

jim@sharktank-01:~/vpp$ git diff
diff --git a/src/plugins/dpdk/device/init.c b/src/plugins/dpdk/device/init.c
index 07cbbf997..5f4cda8fd 100644
--- a/src/plugins/dpdk/device/init.c
+++ b/src/plugins/dpdk/device/init.c
@@ -915,7 +915,8 @@ dpdk_bind_devices_to_uio (dpdk_config_main_t * conf)
       ;
     /* all Intel QAT devices VFs */
     else if (d->vendor_id == 0x8086 && d->device_class == 
PCI_CLASS_PROCESSOR_CO &&
-        (d->device_id == 0x0443 || d->device_id == 0x37c9 || d->device_id == 
0x19e3))
+        (d->device_id == 0x0443 || d->device_id == 0x18a1 || d->device_id == 
0x19e3 || d->device_id == 0x37c9 ||
+        d->device_id == 0x6f55))
       ;
     /* Cisco VIC */
     else if (d->vendor_id == 0x1137 &&
@@ -1483,11 +1484,11 @@ dpdk_update_link_state (dpdk_device_t * xd, f64 now)
   if (LINK_STATE_ELOGS)
     {
       vlib_main_t *vm = vlib_get_main ();
-      ELOG_TYPE_DECLARE (e) =
-      {
-      .format =
+      ELOG_TYPE_DECLARE (e) = {
+       .format =
          "update-link-state: sw_if_index %d, admin_up %d,"
-         "old link_state %d new link_state %d",.format_args = "i4i1i1i1",};
+         "old link_state %d new link_state %d",.format_args = "i4i1i1i1",
+      };

       struct
       {
@@ -1537,11 +1538,11 @@ dpdk_update_link_state (dpdk_device_t * xd, f64 now)
        {
          vlib_main_t *vm = vlib_get_main ();

-         ELOG_TYPE_DECLARE (e) =
-         {
-         .format =
+         ELOG_TYPE_DECLARE (e) = {
+           .format =
              "update-link-state: sw_if_index %d, new flags %d",.format_args
-             = "i4i4",};
+             = "i4i4",
+         };

          struct
          {
jim@sharktank-01:~/vpp$



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13685): https://lists.fd.io/g/vpp-dev/message/13685
Mute This Topic: https://lists.fd.io/mt/32806741/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-