John, et al.,
The vppctl command "set interface l2 tag-rewrite" and the associated API
call "l2_interface_vlan_tag_rewrite" allow an interface to have an L2
tag-rewrite rule
applied or removed from an interface. That interface is usually a subif,
but it
may also apply to a regular (ethernet) interface as well.
Back in April, we patched the interface code to properly return the
VLAN tag-rewrite vtr_op operation on normal interfaces as well as
subinterfaces:
commit fdea5c6a00b74971dbb1b7ec4e25839a871006ca
Author: Alexander Chernavin <acherna...@netgate.com>
Date: Fri Apr 26 10:43:09 2019 -0400
IF: return VTR attributes for all ifs in dump API
With this commit, VTR attributes are shown not only for
subinterfaces
but for all interfaces.
However, that functionality was lost when commit
053204ab039d34a990ff0e14c32ce3b294fcce0e
accidentally stepped on it.
I have submitted a new patch to restore that functionality, and have
added you to the patch reviewers.
This morning, however, I noticed that the same bug is present in the
VAT code as well, in the function vl_api_sw_interface_details_t_handler()
from src/vat/api_format.c, around line 1003 or so. I will update my
patch to fix this code too.
In the meantime, I have a question regarding this behavior. It seems there
is a general lack of understanding here, or perhaps, a very specific lack
of understanding on my part. :-)
All of the code, and all of the tests seem to behave as if the rewrites can
only operate on a sub-interface, and that the configuration can only be
displayed when printed with an associated bridge-domain. I guess I don't
understand that. Shouldn't we be able to have and to see the vlan
tag-rewrite
on a regular (ethernet) interface without it being in a bridge or being a
subif?
Thanks,
jdl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14564): https://lists.fd.io/g/vpp-dev/message/14564
Mute This Topic: https://lists.fd.io/mt/53060174/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
