Folks,

I built a test tool to make vlib_buffer_alloc(...) pretend that the system is 
running out of buffers. In so doing, I found a certain number of 1-off bugs. 
That's not the subject here.

I found a number of these floating around:

  c0 = vlib_buffer_copy (vm, p0);
  ci0 = vlib_get_buffer_index (vm, c0);

C0 can be NULL. This is a coredump waiting to happen. Please don't do this. It 
is not correct.

I'll eventually add "ASSERT (<pointer> != 0)" to vlib_get_buffer_index, and I'm 
going to check every call to vlib_buffer_copy(...) to get rid of this class of 
bug. See https://gerrit.fd.io/r/c/vpp/+/26422

FWIW... Dave
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16033): https://lists.fd.io/g/vpp-dev/message/16033
Mute This Topic: https://lists.fd.io/mt/72872694/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to