Hi Elias, I will let Ole merge the patch it if he is happy with it.
Thanks a lot! —a > On 28 May 2020, at 16:19, Elias Rudberg <elias.rudb...@bahnhof.net> wrote: > > Hi Andrew, > >> Could you push as a separate change the code that reliably gives you >> the error in the LISP unit test > > I tried but today, whatever I do, I cannot reproduce the test failure > anymore. All tests pass now even when I try exactly the same code for > which the test failed yesterday. > > For example, Patchset 4 for https://gerrit.fd.io/r/c/vpp/+/27280 failed > yesterday, but now I created Patchset 8 which is identical to Patchset > 4, and Patchset 8 passes all tests. > > I don't know, maybe something changed in the testing environment since > yesterday, or maybe the issue was never reproducible, it was just a > coincidence that made it seem that way yesterday. > > The good news is that the fix I wanted to do now passes the tests also > when written as Ole suggested, with collector_port as u32 and a bounds > check added: > > https://gerrit.fd.io/r/c/vpp/+/27280 > > It would be great if that could get merged. > > Best regards, > Elias >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16563): https://lists.fd.io/g/vpp-dev/message/16563 Mute This Topic: https://lists.fd.io/mt/74491544/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
