Make sense to me, as saving trace data is already impacting "normal" performance. The extra function call is probably not much more overhead. -John
From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Dave Barach via lists.fd.io Sent: Monday, June 08, 2020 10:13 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] vlib_add_trace(...) - stop inlining? Folks, It looks to me like inlining vlib_add_trace(...) is probably a mistake in terms of code bloat. Does anyone hate the idea of changing it to a standard function? Thanks... Dave
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16689): https://lists.fd.io/g/vpp-dev/message/16689 Mute This Topic: https://lists.fd.io/mt/74752449/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
