OK, pushed another patch-set to remove the old command. Thanks... Dave
From: Vratko Polak -X (vrpolak - PANTHEON TECH SRO at Cisco) <vrpo...@cisco.com> Sent: Thursday, November 26, 2020 8:48 AM To: Dave Barach <v...@barachs.net>; 'Andrew 👽 Yourtchenko' <ayour...@gmail.com> Cc: csit-...@lists.fd.io; vpp-dev@lists.fd.io Subject: RE: [vpp-dev] [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] In the meantime, [0] got merged everywhere important. You can try to remove the old CLI to see if it passes now. Vratko. From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of Dave Barach Sent: Thursday, 2020-November-26 14:36 To: 'Andrew 👽 Yourtchenko' <ayour...@gmail.com <mailto:ayour...@gmail.com> >; Vratko Polak -X (vrpolak - PANTHEON TECH SRO at Cisco) <vrpo...@cisco.com <mailto:vrpo...@cisco.com> > Cc: csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] Thanks for the pointer(s), guys. Fixed, new patch-set uploaded... From: Andrew 👽 Yourtchenko <ayour...@gmail.com <mailto:ayour...@gmail.com> > Sent: Thursday, November 26, 2020 8:18 AM To: Dave Barach <v...@barachs.net <mailto:v...@barachs.net> > Cc: vrpo...@cisco.com <mailto:vrpo...@cisco.com> ; csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] I see the failure in the doc verify job: 22:49:10 Processing siphon for markdown from clicmd.siphon... 22:49:10 INFO:siphon.process.clicmd:Parsing items in file "build-root/docs/siphon_fragments/clicmd.siphon". 22:49:12 ERROR:siphon.process.clicmd:Exception parsing item: { 22:49:12 "block": "VLIB_CLI_COMMAND (elog_trace_command, static) =\n ;\n", 22:49:12 "directory": "src/vlib", 22:49:12 "file": "src/vlib/cli.c", 22:49:12 "line_end": 1592, 22:49:12 "line_start": 1591, 22:49:12 "siphon_block": "" 22:49:12 } 22:49:12 VLIB_CLI_COMMAND (elog_trace_command, static) = 22:49:12 ; 22:49:12 22:49:12 Traceback (most recent call last): 22:49:12 File "/w/workspace/vpp-docs-verify-master-ubuntu1804-x86_64/doxygen/siphon-process", line 72, in <module> 22:49:12 processor.load_json(args.input) 22:49:12 File "/w/workspace/vpp-docs-verify-master-ubuntu1804-x86_64/doxygen/siphon/process.py", line 203, in load_json 22:49:12 “make doxygen” locally shows the problem as well. Removing the space in front of the open/close braces in the elog trace block makes it happy. 🤷‍♂️ FWIW. --a On 26 Nov 2020, at 13:36, Dave Barach <v...@barachs.net <mailto:v...@barachs.net> > wrote:  OK, thanks for [0]. Even with the old debug CLI supported on the vpp side, the patch continues to fail validation. I’m going to try again (“recheck”) and see what happens. D. From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via lists.fd.io Sent: Thursday, November 26, 2020 4:47 AM To: Dave Barach <v...@barachs.net <mailto:v...@barachs.net> > Cc: csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] Compatibility enhancement on CSIT side: [0]. > easy enough to support both “elog trace” and “event-logger trace” on the vpp > side. When [0] is merged (also to oper branch), the support on VPP side can be dropped. > add a binary API and use it in the csit robot framework +1 to that, especially if the API is marked as Production, so it is covered by [1]. Vratko. [0] <https://gerrit.fd.io/r/c/csit/+/30147> https://gerrit.fd.io/r/c/csit/+/30147 [1] <https://wiki.fd.io/view/VPP/ApiChangeProcess> https://wiki.fd.io/view/VPP/ApiChangeProcess From: csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> <csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> > On Behalf Of Dave Barach Sent: Wednesday, 2020-November-25 22:42 To: csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] <csit-workspace>/resource/libraries/python/VPPUtil.py appears responsible: @staticmethod def vpp_enable_elog_traces(node): """Enable API/CLI/Barrier traces on the specified topology node. :param node: Topology node. :type node: dict """ PapiSocketExecutor.run_cli_cmd_on_all_sockets( node, u"elog trace api cli barrier") For the moment, it’s easy enough to support both “elog trace” and “event-logger trace” on the vpp side. The obvious medium-term answer would be to add a binary API and use it in the csit robot framework, instead of depending on debug CLI [which is never a Good Idea]. FWIW... Dave
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18156): https://lists.fd.io/g/vpp-dev/message/18156 Mute This Topic: https://lists.fd.io/mt/78526554/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
