Andrew,
Sorry, I am used to github which auto-merges two commits and missed using gerrit ‘s –amend in my 2nd commit. I did what you unicasted to me and now the latest diffs are available in review. https://gerrit.fd.io/r/c/vpp/+/30848 thanks, Hemant From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Andrew Yourtchenko Sent: Tuesday, January 19, 2021 4:40 PM To: hem...@mnkcg.com Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] classifier howto? On 19 Jan 2021, at 22:17, hem...@mnkcg.com <mailto:hem...@mnkcg.com> wrote: Andrew, Great suggestion – thanks. I updated the code after taking care of your comments. https://gerrit.fd.io/r/c/vpp/+/30848/1 Seems like you pushed two different changes - the better approach is to reuse the “Change-ID: xxxx” value from the previous edit by doing “git commit —amend”, then the edits show up as the revisions of the same change. (Which, while being a bit counterintuitive at first, makes the gerrit workflow more powerful than eg GitHub). —a I didn’t update classify.api and classify_api.c for the “Fancy_new_call” yet. In another Pull Request (PR), I’d like to develop a new plugin that uses the classify entry’s value and write packet tests etc. Cheers, Hemant From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of Andrew Yourtchenko Sent: Tuesday, January 19, 2021 2:05 PM To: hem...@mnkcg.com <mailto:hem...@mnkcg.com> Cc: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] classifier howto? Meta-comment: old_boring_call(foo) { /* meat */ } => Fancy_new_call(foo, bar) { /* new meat */ } Old_boring_call(foo) { Fancy_new_call(foo, 0); } This way you don’t have to patch umpteen unrelated places. --a On 19 Jan 2021, at 19:26, hemant via lists.fd.io <hemant=mnkcg....@lists.fd.io <mailto:hemant=mnkcg....@lists.fd.io> > wrote: Yay, I issued my first code review for VPP using gerrit for the issue of this email! https://gerrit.fd.io/r/c/vpp/+/30844 The JIRA issue I filed today is at: https://jira.fd.io/browse/VPP-1967 Thanks all for replying. Hemant From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of hemant via lists.fd.io Sent: Monday, January 18, 2021 8:41 PM To: hem...@mnkcg.com <mailto:hem...@mnkcg.com> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] classifier howto? Please see this PR to fix what I need. https://github.com/FDio/vpp/pull/33 Please review – thanks. Hemant From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of hemant via lists.fd.io Sent: Monday, January 18, 2021 10:52 AM To: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] classifier howto? I am used to the bihash’s easy to understand key-value pair API to program an entry for table lookup using the hash. https://github.com/FDio/vpp/blob/master/src/vppinfra/bihash_48_8.h#L39 The value in the struct is a u64. To see how I program a classifier entry for use by the data plane, I looked at the classifier entry data structure: https://github.com/FDio/vpp/blob/master/src/vnet/classify/vnet_classify.h#L66 The data structure uses a “u32x4 key[0];” key, but where is the value? I am used to seeing a key and value in an entry. Is “u32 opaque_index” the value? If yes, why does bihash use a “u64” for value but the classifier uses a u32? If the classifier table is hit, my next_node needs the “value” associated with the key that incurred the table hit. After all, for bihash, e.g., clib_bihash_search_48_8() API returns an explicit value. I plan to use the API in vnet_classify_add_del_session() to program ip4 and ip6 src and dst address prefix matching. Thanks, Hemant
smime.p7s
Description: S/MIME cryptographic signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18557): https://lists.fd.io/g/vpp-dev/message/18557 Mute This Topic: https://lists.fd.io/mt/79925983/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
