Ben, It was not intended toward you at all. In fact, in my experience, you are very helpful. I was only looking to highlight cases that did not specifically benefit me.
Would you like a different change for me to highlight? How about https://gerrit.fd.io/r/c/vpp/+/27349? That is mine, though. Let me share with the list, another illustrative example of the actual point I'm trying to make. I reached out to Florin and Ben about an ASAN crash in the debug CI job. I am the first to admit that I know nothing about ASAN. Ben promptly submitted a fix, but Florin said he was in the process of a significant refactor and asked if it could be held back until after then. This is yet another reason why we should not auto-delete submissions. Period. Most of you have a VPP dev environment setup already, so tossing in a changeset is no big thing. But when folks go to the wiki, follow the steps for all the hoops that they have to jump through to get a change submitted, and for a change to be ignored is just wrong. If someone cares enough about the project to go through the effort, they deserve feedback. A while back, Ole asked on the list, if he should set up a wiki page. I said I was against it, because anyone can edit a wiki page. He, however, is one of a very small group who can actually clear the backlog. If we truly want to grow the community, we have to act in ways that welcome folks to the community. Ignoring contributions and auto-deleting them is not welcoming in my opinion. If one thinks that auto-delete is a valid option, then auto-submit must be equally valid. Both address a MAINTAINERS lack of attention. In an auto-delete scenario, the maintainer is rewarded for ignoring the changeset, is an auto-submit, he is not. To your point, I agree with you. I don't want to touch other MAINTAINERs areas either, that's why I've been just leaving +1's, as I said in my original post, as my practice lately. Dave, Let me know how I can help. On Fri, Jan 29, 2021 at 9:51 AM Benoit Ganne (bganne) <bga...@cisco.com> wrote: > Hi Paul, > > as you refer to this specific story which is close to my heart (as I am > the one who triggered the whole drama by -2'ed), let me clarify: > > > The Netgate folks had a changeset they were waiting a month or so for a > > review, then they were told that it was too close to the release to merge > > it. It was merged, but the argument that "because we held you back, > we're > > going to hold you back some more" is very anti-community. > > I am not disagreeing we have an issue with the merging process, but this > is not what happened for this specific change (see below). > I apologized to Jon (patch author) and from the discussion I had with him > we both agreed we were acting in good faith. > Anyway, the net result of all this is I am now reluctant to review > anything for which I am not a maintainer (so less review manpower). > > Here is the story from my point-of-view: > * I did a patch that I abandoned on Jon's request (because Jon's and my > were trying to fix the same problem but Jon's was more complete) and then > did initial reviews on Jon's patch when he pushed it: I was looking forward > for it to be merged and spent time on it > * then I saw a number of updates by Jon (-2, -1, new patches) between > patchset 2 on Nov 30 until the last significant change with Patchset 5 on > Dec 7 > => I did not spent time to review waiting for the final version, because I > understood Jon were still actively debugging/updating it. Reviews take > time, so I'd rather review when it is considered as "done" by the author > * it is only when Jon pinged again that I looked at it again and asked > Andrew and Dave, respectively because of their release manager hat and > maintainer hat > > I am not saying it was the best way of managing it, and this is definitely > not how it was received/understood. I understand that. But there was no > nefarious anti-community intent. > > Best > ben >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18630): https://lists.fd.io/g/vpp-dev/message/18630 Mute This Topic: https://lists.fd.io/mt/80169540/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
