Ben,
Your patch fixed the issue [0] (x86_64 passes too)!
Thanks,
-daw-
[0]
https://jenkins.fd.io/sandbox/job/daw_30773-vpp-verify-master-ubuntu2004-aarch64/4/
https://jenkins.fd.io/sandbox/job/daw_30773-vpp-verify-master-ubuntu2004-x86_64/3/
On 2/11/2021 3:06 PM, Dave Wallace via lists.fd.io wrote:
Ben,
Excellent debugging work!
I will rebase my gerrit change onto yours, retest in the Jenkins
Sandbox, and report back.
Thanks,
-daw-
On 2/11/21 2:18 PM, Benoit Ganne (bganne) wrote:
Hi Dave,
There are still 6 ikev2 test failures from this test run that need to be
resolved.
I identified the issue: undefined behaviour + aggressive gcc optimization.
The tentative fix is here:https://gerrit.fd.io/r/c/vpp/+/31240
Note that for this to happen, you need both:
- compile with gcc
- use gcc memcpy builtin
This is the case for ARM64 but not x86, as we do not use gcc memcpy builtin on
x86.
It looks like there are other cases where we call memcpy with NULL
pointers:https://gerrit.fd.io/r/c/vpp/+/31241
I am going to chase them down.
Best
ben
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18738): https://lists.fd.io/g/vpp-dev/message/18738
Mute This Topic: https://lists.fd.io/mt/80495347/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
