Hi Dave, Thanks for catching this ! Also we weren't needing the --target option anymore, sorry for the trouble :) [0] Removes it and should work with cmake 3.20.
We might face future issues as quicly requires compatibility with 2.8.11 which triggers a deprecation warning in 3.20. I'll try to keep an eye on this. Cheers -Nathan [0] https://gerrit.fd.io/r/c/vpp/+/32289 Le mer. 12 mai 2021 à 16:27, Dave Barach <v...@barachs.net> a écrit : > Let me answer my own question: > > > > $ /usr/bin/cmake --version > > cmake version 3.16.3 > > > > Works. > > > > $ /usr/local/bin/cmake.new --version > > cmake version 3.19.xxx > > > > Fails as shown below. > > > > As in: cmake 3.19 appears not to support the “—target=quicly” argument... > > > > FWIW... Dave > > > > *From:* vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> *On Behalf Of *Dave > Barach > *Sent:* Wednesday, May 12, 2021 10:13 AM > *To:* vpp-dev@lists.fd.io > *Subject:* [vpp-dev] "make install-ext-deps" failing w/ master/latest? > > > > Any clue what this is all about? > > > > --- validating quicly 0.1.3-vpp checksum > > --- extracting quicly 0.1.3-vpp > > --- patching quicly 0.1.3-vpp > > Applying patch: 0001-cmake-install.patch > > patching file CMakeLists.txt > > Applying patch: 0002-cmake-install-picotls.patch > > patching file deps/picotls/CMakeLists.txt > > Applying patch: 0003-unused-is-late-ack.patch > > patching file lib/quicly.c > > --- configuring quicly 0.1.3-vpp - log: > /scratch/vpp-ext-deps/build/external/deb/_build/quicly.config.log > > --- building quicly 0.1.3-vpp - log: > /scratch/vpp-ext-deps/build/external/deb/_build/quicly.build.log > > CMake Error: Unknown argument --target=quicly > > CMake Error: Run 'cmake --help' for all supported options. > > make[5]: *** [packages/quicly.mk:48: > /scratch/vpp-ext-deps/build/external/deb/_build/.quicly.build.ok] Error 1 > > make[5]: Leaving directory '/scratch/vpp-ext-deps/build/external' > > make[4]: *** [debian/rules:25: override_dh_install] Error 2 > > make[4]: Leaving directory '/scratch/vpp-ext-deps/build/external/deb' > > make[3]: *** [debian/rules:17: binary] Error 2 > > make[3]: Leaving directory '/scratch/vpp-ext-deps/build/external/deb' > > dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned > exit status 2 > > make[2]: *** [Makefile:75: vpp-ext-deps_21.06-8_amd64.deb] Error 2 > > make[2]: Leaving directory '/scratch/vpp-ext-deps/build/external' > > make[1]: *** [Makefile:82: install-deb] Error 2 > > make[1]: Leaving directory '/scratch/vpp-ext-deps/build/external' > > make: *** [Makefile:597: install-ext-deps] Error 2 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19378): https://lists.fd.io/g/vpp-dev/message/19378 Mute This Topic: https://lists.fd.io/mt/82773115/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
