This is a different code path which might need the same sort of fix.
Looks likely that you sent a VL_API_DELETE_LOOPBACK message. AFAICT that message is not marked thread-safe, so it will be processed on thread 0 with the thread barrier held. D. From: [email protected] <[email protected]> On Behalf Of sontu mazumdar Sent: Friday, June 18, 2021 5:57 AM To: [email protected] Subject: Re: [vpp-dev] "unix-cli-local" node corruption in node_by_name hash #vpp #vpp-dev Hi Dave, This hash node key corruption I observed while debugging a VPP crash due to node_by_name hash access which seems to be corrupted. So I thought the unix-cli-local node might be the root cause, but after the patch also we saw the crash again. The bt looks like below. * Frame 00: /lib64/libpthread.so.0(+0x14a90) [0x7ff07d7dea90] * Frame 01: /lib64/libvppinfra.so.20.05.1(hash_memory+0x30) [0x7ff07d9548a0] * Frame 02: /lib64/libvppinfra.so.20.05.1(+0x23ce0) [0x7ff07d954ce0] * Frame 03: /lib64/libvppinfra.so.20.05.1(_hash_set3+0xfd) [0x7ff07d955dfd] * Frame 04: /lib64/libvppinfra.so.20.05.1(+0x24c71) [0x7ff07d955c71] * Frame 05: /lib64/libvlib.so.20.05.1(vlib_node_rename+0xa9) [0x7ff07daf2b49] * Frame 06: /lib64/libvnet.so.20.05.1(vnet_delete_hw_interface+0x4eb) [0x7ff07eae3f9b] * Frame 07: /lib64/libvnet.so.20.05.1(ethernet_delete_interface+0x713) [0x7ff07eb14673] * Frame 08: /lib64/libvnet.so.20.05.1(vnet_delete_loopback_interface+0x119) [0x7ff07eb16169] * Frame 09: /lib64/libvnet.so.20.05.1(+0xf816b4) [0x7ff07eaf06b4] * Frame 10: /lib64/libvlibmemory.so.20.05.1(vl_msg_api_socket_handler+0x11c) [0x7ff07f3a101c] * Frame 11: /lib64/libvlibmemory.so.20.05.1(vl_socket_process_api_msg+0x18) [0x7ff07f38e9b8] I have one question regarding the changes, don't we need to take thread_barrier lock before updating the hash node_by_name ? Regards, Sontu
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19612): https://lists.fd.io/g/vpp-dev/message/19612 Mute This Topic: https://lists.fd.io/mt/83471274/21656 Mute #vpp:https://lists.fd.io/g/vpp-dev/mutehashtag/vpp Mute #vpp-dev:https://lists.fd.io/g/vpp-dev/mutehashtag/vpp-dev Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
