Dear Stanislav, It doesn’t look to me as a thread safe solution.
i.e imagine 2 threads call pool_put_will expand on the same time, and there is just one free slot. Both will get negative answer, but 2nd put operation will actually expand. — Damjan > On 04.11.2021., at 18:24, Stanislav Zaikin <zsta...@gmail.com> wrote: > > > Hello folks, > > In a multi-threaded environment (in my case I have 2 workers) I observed a > crash, and thanks to Neale, it turned out that free_bitmap may expand while > doing pool_put. > Let's say one thread is doing pool_put, while another thread is calling > "pool_elt_at_index". I observed different addresses before and after checking > "ASSERT (! pool_is_free (p, _e))" in that macro. > > I prepared a patch [0], but it's kind of ugly. We don't have asserts in > release mode, so why should we care about it? > > On the other hand, 2 different threads can do 2 pool_puts simultaneously and > we can lose one free element in the pool (and also additionally allocated > bitmap). > > For me, it's a place where it would be nice to have an mt-safe vec. What do > you think? > > [0] - https://gerrit.fd.io/r/c/vpp/+/34332 > > -- > Best regards > Stanislav Zaikin > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#20425): https://lists.fd.io/g/vpp-dev/message/20425 Mute This Topic: https://lists.fd.io/mt/86821639/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
