Hi Laszlo, Thanks! A few comments: - I think it would be easier to just merge both patches - I would put the Dockerfile under extras/rpm instead of a dedicated directory, alongside a small README to explain how to use it for testing - you should add yourself in MAINTAINERS as the maintainer for rpm packaging. A maintainer duty is to review patches on its subsystem (rpm packaging in your case) in gerrit and +1 if they are ready for merging so a committer can merge them, and to answer/fix issues when reported
Best ben > -----Original Message----- > From: Laszlo Király <laszlo.kir...@est.tech> > Sent: vendredi 5 novembre 2021 15:56 > To: vpp-dev@lists.fd.io > Cc: Benoit Ganne (bganne) <bga...@cisco.com> > Subject: Re: [vpp-dev] Reason for removing SUSE packaging support > > Hello, > > I pushed the patches for providing support to build vpp on opensuse leap: > https://gerrit.fd.io/r/c/vpp/+/34356 > > https://gerrit.fd.io/r/c/vpp/+/34357 > > The rpm build can be tried out by the provided docker manifest file: > docker build -f extras/docker/build/Dockerfile.opensuse . > > > Could you give me some advice how to continue with this? Can I add someone > as a reviewer? > -- > Laszlo > > ________________________________ > > From: Benoit Ganne (bganne) <bga...@cisco.com> > Sent: Monday, July 26, 2021 10:08 AM > To: Laszlo Király <laszlo.kir...@est.tech> > Cc: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> > Subject: RE: [vpp-dev] Reason for removing SUSE packaging support > > If you provide patches and volunteer to be the maintainer that would be > great. The main request is to be reactive on the code you maintain (answer > users and/or bug reports). > You can start by submitting patches and an entry in MAINTAINERS. > I suspect the best would be to have extras/rpm/centos/ and > extras/rpm/suse/ but I am no expert. > > Best > ben > > > -----Original Message----- > > From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Laszlo > Király > > Sent: lundi 26 juillet 2021 08:35 > > To: Damjan Marion <dmar...@me.com> > > Cc: vpp-dev@lists.fd.io > > Subject: Re: [vpp-dev] Reason for removing SUSE packaging support > > > > Thanks for the clarification. > > Currently we are building the vpp in SUSE environment and probably must > be > > maintained in the long term. If I would like to contribute to build > > support for opensuse-leap which are the expectations? Are there any > other > > todos beside the update of documentation and build scripts? > > > > -- > > Laszlo Kiraly > > Ericsson Software Technology > > laszlo.kir...@est.tech > > > > ________________________________ > > > > From: Damjan Marion <dmar...@me.com> > > Sent: Monday, July 19, 2021 12:08 PM > > To: Laszlo Király <laszlo.kir...@est.tech> > > Cc: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> > > Subject: Re: [vpp-dev] Reason for removing SUSE packaging support > > > > > > Simply because there was nobody interested to volunteer to maintain it. > > > > - > > Damjan > > > > > > > > > > On 19.07.2021., at 12:04, Laszlo Király <laszlo.kir...@est.tech> > > wrote: > > > > > > > > > > Hello, > > > > Could somebody evolve why the build support for Suse was removed? > > Which was the last release with support for build on openSuse? I > > found this commit only mentioning this removal: > > > > commit bc35f469c89daf0126937580b6972516b5007d3a > > Author: Dave Wallace <dwallac...@gmail.com> > > Date: Fri Sep 18 15:35:01 2020 +0000 > > > > build: remove opensuse build infra > > > > - VPP on opensuse has not been supported > > for several releases. > > > > Type: fix > > > > Signed-off-by: Dave Wallace <dwallac...@gmail.com> > > Change-Id: I2b5316ad5c20a843b8936f4ceb473f932a5338d9 > > > > > > > > Is it planned to add it back soon? Or later? > > > > -- > > Laszlo Kiraly > > Ericsson Software Technology > > > > laszlo.kir...@est.tech > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#20438): https://lists.fd.io/g/vpp-dev/message/20438 Mute This Topic: https://lists.fd.io/mt/84304700/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
