Hi, I saw the change but had not had time to review it yet. Hopefully I'll be able to do so in the coming days. We are already in RC2 for 23.02 so I do not think it will be part of it as it does not seem to be a critical bug fix.
Best ben > -----Original Message----- > From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Pei, Yulong > Sent: Thursday, February 9, 2023 3:41 > To: Benoit Ganne (bganne) <bga...@cisco.com> > Cc: vpp-dev@lists.fd.io; Dave Wallace (dwallace) <dwall...@cisco.com> > Subject: Re: [vpp-dev] help with review > > Hi Benoit and vpp-dev, What is your opinion about this patch > https://gerrit.fd.io/r/c/vpp/+/38135 ? Could it be merged in FD.io 23.02 > ? > > Best Regards > Yulong Pei > > -----Original Message----- > From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Pei, Yulong > Sent: Tuesday, February 7, 2023 10:10 PM > To: Benoit Ganne (bganne) <bga...@cisco.com> > Cc: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] help with review > > Hi Benoit, A new one also need your help to review > https://gerrit.fd.io/r/c/vpp/+/38135 , thanks a lot. > > -----Original Message----- > From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Benoit Ganne > (bganne) via lists.fd.io > Sent: Thursday, February 2, 2023 6:37 PM > To: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] help with review > > Hi, thanks for the head's up. > > > Please help to review below patches again, all your comments were > > addressed. Thanks a lot. > > https://gerrit.fd.io/r/c/vpp/+/38008 > > Merged! > > > https://gerrit.fd.io/r/c/vpp/+/38009 > > A few minor comments left on that one, but then we should be good to > merge. > > Thanks, > ben
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22570): https://lists.fd.io/g/vpp-dev/message/22570 Mute This Topic: https://lists.fd.io/mt/96695094/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
