Hi, Yes I fully agree with Andrew on changing APIs. Though the api was broken in the first place. If used incorrect message is returned. Because of that I am not even sure if it is functional at all. It is more likely that nobody before addressed this issue because this feature is not used.
So I would suggest either to set it as deprecated and add v2 which will be flagged as experimental or change it on master because It might not be even functional. Best regards, Filip Varga st 22. 3. 2023 o 14:11 Andrew Yourtchenko <ayour...@gmail.com> napísal(a): > Hey Daniel, > > I had a quick look and it looks like the APIs in question are also not > marked as experimental ? > > If I am right, then to me seems like a silent behavior change to a > production API - something we have heard repeated complaints from the > downstream consumers for…. > > I had -2’d it for now - we should definitely discuss it here first; as is > i would consider it a no-go even for a master, but I am happy to hear > others opinions and be convinced otherwise :-) > > --a > > On 22 Mar 2023, at 10:36, Daniel Béreš <daniel.be...@pantheon.tech> wrote: > > > > Hello Guys, > > I wrote a short patch to fix a couple api handlers for nat44ed [1] . > <https://gerrit.fd.io/r/c/vpp/+/38459>It was probably forgotten, so I'm > reminding myself. > > I still have a question about whether it is possible to cherry-pick the > patch to vpp v23.02 and 22.10. > > [1] https://gerrit.fd.io/r/c/vpp/+/38459 > > > Thanks, > Daniel > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22748): https://lists.fd.io/g/vpp-dev/message/22748 Mute This Topic: https://lists.fd.io/mt/97774402/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
