The / caused v2 cut the ids into invalid (Gigabit0/1/0 -> Gigabit0 vs Gigabit0_1_0) ids but now with the new way to cut interface path it might work. /Jimmy ________________________________ From: [email protected] <[email protected]> on behalf of Pim van Pelt via lists.fd.io <[email protected]> Sent: Monday, February 16, 2026 23:44 To: [email protected] <[email protected]> Cc: [email protected] <[email protected]> Subject: Re: [vpp-dev] Regression in metric naming in prometheus exporter for 26.02-rc2
Hoi The change to restore ‘-‘ as a valid char looks good to me. Remind me though, what was the problem that the original change to sanitize() was solving? Prometheus allows any UTF8 character in label values. Groet, Pim — Pim van Pelt / PBVP1-RIPE https://ipng.ch/ On 16 Feb 2026, at 10:33, Jimmy Björklund via lists.fd.io <[email protected]> wrote: Hi, do anyone see an issue with changing the code to this ? // Jimmy { for (int i = 0; i < len; i++) { - if (!isalnum (str[i])) - str[i] = '_'; if (str[i] == '/') str[i] = '_'; + else if (str[i] == '-') + continue; + else if (!isalnum (str[i])) + str[i] = '_'; } } Sent from Outlook for Mac From: [email protected] <[email protected]> on behalf of Jimmy Björklund via lists.fd.io <[email protected]> Date: Monday, 16 February 2026 at 08:58 To: [email protected] <[email protected]> Subject: Re: [vpp-dev] Regression in metric naming in prometheus exporter for 26.02-rc2 Ok, I now see what you mean, I'll investigate it and see what I can do. /Jimmy Sent from Outlook for Mac From: [email protected] <[email protected]> on behalf of Carlos Aguado via lists.fd.io <[email protected]> Date: Sunday, 15 February 2026 at 21:49 To: [email protected] <[email protected]> Subject: Re: [vpp-dev] Regression in metric naming in prometheus exporter for 26.02-rc2 Thank you! The line I refer to replaces any non-alphanumeric character with an underscore, not only slash though. In this case, the string refers to a node name that contains an interface name. I also use the exporter v2 and didn't see this issue with slash before, so rolling this out effectively renames metrics which makes their history a bit less useful after deployment. Added a screenshot to the issue to demo the effect of removing only the token's sanitization. Carlos On Sun, 15 Feb 2026 at 20:13, Jimmy Björklund via lists.fd.io<http://lists.fd.io/> <[email protected]<mailto:[email protected]>> wrote: This is not a regression it’s changed so make the exports consistent and work with v2. The same interface was in some places exported with / and in some places with _ Jimmy Sent from Outlook for iOS<https://aka.ms/o0ukef> ________________________________ From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> on behalf of Carlos Aguado via lists.fd.io<http://lists.fd.io/> <[email protected]<mailto:[email protected]>> Sent: Sunday, February 15, 2026 6:26:24 PM To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> Subject: [vpp-dev] Regression in metric naming in prometheus exporter for 26.02-rc2 Hi, Testing the v26.02-rc2 release, I have found a regression in the prometheus exporter that I can only attribute to a recent commit. I logged the issue in GitHub but please let me share it here to understand the intent so I can propose a change that fits the release window if warranted. https://github.com/FDio/vpp/issues/3686 Best, Carlos
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#26817): https://lists.fd.io/g/vpp-dev/message/26817 Mute This Topic: https://lists.fd.io/mt/117826006/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/14379924/21656/631435203/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
