https://gerrit.fd.io/r/c/vpp/+/45598 should fix left-over failed_tests
On Fri, Apr 24, 2026 at 8:12 AM Klement Sekera via lists.fd.io <ksekera= [email protected]> wrote: > I see the problem, Matt’s suggestion is good. I never use retries hence I > didn’t realize it would leave a file behind even if it ultimately passes. > I’ll push a patch to address this. > > Still, for failure cases the script expecting a directory needs to be > changed too. Are the ci scripts part of VPP codebase? > > On 24 Apr 2026, at 07:58, Jerome Tollet via lists.fd.io <jtollet= > [email protected]> wrote: > > > Hello, > I had similar issues yesterday but after a « recheck » it seems to be > working again… > Jerome > > *De : *[email protected] <[email protected]> de la part de Pim van > Pelt via lists.fd.io <[email protected]> > *Date : *vendredi, 24 avril 2026 à 07:03 > *À : *[email protected] <[email protected]> > *Objet : *Re: [vpp-dev] CI failures > /tmp/vpp-failed-unittests/failed_tests/* > > Hoi, > > Similar issue here - https://github.com/FDio/vpp/actions/runs/24840846206 > <https://www.google.com/url?q=https://github.com/FDio/vpp/actions/runs/24840846206&source=gmail-imap&ust=1777615111000000&usg=AOvVaw3Md1xd0OpkTK8l_-uij8qg> > fails > in the same place with a 'cp -a' error, even though I think the tests in > the gerrit are OK. > > groet, > Pim > > On 24.04.2026 02:57, Matthew Smith via lists.fd.io wrote: > > There was a similar issue with a patch I uploaded - > https://github.com/FDio/vpp/actions/runs/24861252871/job/72787655509 > <https://www.google.com/url?q=https://github.com/FDio/vpp/actions/runs/24861252871/job/72787655509&source=gmail-imap&ust=1777615111000000&usg=AOvVaw2iolHl3BB8Z79oU9kehVNA>. > The 'make test' step ultimately succeeded but the first pass at running > unit tests had 2 errors so those tests had to be rerun. Should the > failed_tests file be removed when the retries are successful? > > -Matt > > > On Thu, Apr 23, 2026 at 2:56 AM Klement Sekera via lists.fd.io > <https://www.google.com/url?q=http://lists.fd.io&source=gmail-imap&ust=1777615111000000&usg=AOvVaw2wthrKs4g61xVw_1_ifa8h> > <[email protected]> wrote: > > Hmm unless the ci script assumes that it only contains vpp-unittest-<class > name> directories which has been the truth so far. The reason why my verify > job passed is because the failed_test file is produced only when a test > fails. > > So that would indicate that your verify job(s) failed and then ci choked > on the unexpected results. > > If the changes are good, a recheck should get you moving. > > CI script needs to catch up of course. > > Regards, > Klement > > On 23 Apr 2026, at 08:06, Klement Sekera via lists.fd.io > <https://www.google.com/url?q=http://lists.fd.io&source=gmail-imap&ust=1777615111000000&usg=AOvVaw2wthrKs4g61xVw_1_ifa8h> > <[email protected]> wrote: > > > I'm suspecting https://gerrit.fd.io/r/c/vpp/+/45475 > <https://www.google.com/url?q=https://www.google.com/url?q%3Dhttps://gerrit.fd.io/r/c/vpp/%252B/45475%26source%3Dgmail-imap%26ust%3D1777529201000000%26usg%3DAOvVaw3AiLXAe27KRXOt3nyMJ_vc&source=gmail-imap&ust=1777615111000000&usg=AOvVaw3Welqi8u1Uj_ekUBtey2Ri> > > But that run passed. > > I don't see why the tool which you pasted output from thinks it's a > directory... > > On Thu, Apr 23, 2026 at 5:06 AM G. Paul Ziemba via lists.fd.io > <https://www.google.com/url?q=https://www.google.com/url?q%3Dhttp://lists.fd.io%26source%3Dgmail-imap%26ust%3D1777529201000000%26usg%3DAOvVaw0uVtbx4gAQl0320gQOPJub&source=gmail-imap&ust=1777615111000000&usg=AOvVaw2F_PdeZ_0e_cc7Wo_4GvM1> > <[email protected]> wrote: > > I've been seeing these failures today; several unrelated gerrit > changes are having this error as well. Seems like something broke? > > + archives_dir=/scratch/docker-build/vpp/archives > + unittest_failed_dir=/tmp/vpp-failed-unittests > ++ ls /tmp/vpp-failed-unittests > + for failed_test in $(ls "$unittest_failed_dir") > + failed_test_dir=/scratch/docker-build/vpp/archives/failed_tests > + '[' '!' -e /scratch/docker-build/vpp/archives/failed_tests ']' > + mkdir -p /scratch/docker-build/vpp/archives/failed_tests > + cp -a '/tmp/vpp-failed-unittests/failed_tests/*' > /scratch/docker-build/vpp/archives/failed_tests > cp: cannot stat '/tmp/vpp-failed-unittests/failed_tests/*': Not a > directory > Error: Process completed with exit code 1. > > > > > > > > > > > > -- > Pim van Pelt <[email protected]> <[email protected]> > PBVP1-RIPE https://ipng.ch/ > <https://www.google.com/url?q=https://ipng.ch/&source=gmail-imap&ust=1777615111000000&usg=AOvVaw3ri6MBb3OvqJfJ4k6vnkrR> > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#26984): https://lists.fd.io/g/vpp-dev/message/26984 Mute This Topic: https://lists.fd.io/mt/118966663/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/14379924/21656/631435203/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
