Thanks for creating the JIRA entry and for attaching the patch. I've reviewed and committed the (2nd) patch.
Cheers, Till On Jun 18, 2012, at 7:01 PM, Till Westmann wrote: > Eldon, > > thanks for the patch - I received the e-mail. I didn't manage to review it > yet, but for the future I think that we should create JIRA entries for the > bugs/features that we're working on. That way we can keep the problem and the > solution together and we also don't have to fight with patches in e-mail. > > Cheers, > Till > > On Jun 18, 2012, at 4:47 PM, Eldon Carman wrote: > >> All arthmetic functions are with a patch (in a separate e-mail) with >> the exception functions with a parameter of time, datetime or date. >> Currently in VXQuery these pointable classes (time, datetime, and >> date) have just been stubbed out. The pointable classes are missing >> functions to call for specific data values. YMDuration and DTDuration >> parameters have been set as type long so they have been included the >> implemented functions. The asterix project is working on temporal >> features and they are using the following classes for these types. We >> could use these as a base for our implementation. >> >> Date >> http://code.google.com/p/asterixdb/source/browse/branches/asterix_stabilization_temporal_fixes/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/ADate.java >> >> DateTime >> http://code.google.com/p/asterixdb/source/browse/branches/asterix_stabilization_temporal_fixes/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/ADateTime.java >> >> Time >> http://code.google.com/p/asterixdb/source/browse/branches/asterix_stabilization_temporal_fixes/asterix-om/src/main/java/edu/uci/ics/asterix/om/base/ATime.java >> >> What do you think? >
