[
https://issues.apache.org/jira/browse/VXQUERY-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397922#comment-13397922
]
Vinayak Borkar commented on VXQUERY-34:
---------------------------------------
Great!
One more comment: The evaluate call in FnUpper/FnLower can be moved to the
abstract super class -- its the same code in both classes. Move it up, and make
it final. So the only method in FnUpper and FnLower will deal with transcoding
a character.
Once you do that, you can inline the getTranscoded... method into the evaluate
method and make the byte[] stringResult field stack local.
Thanks,
Vinayak
> Basic String Functions
> -----------------------
>
> Key: VXQUERY-34
> URL: https://issues.apache.org/jira/browse/VXQUERY-34
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Labels: patch
> Attachments: BasicStringFunctions2.patch, BasicStringFunctions3.patch
>
>
> The basic string functions to build help with basic queries.
> fn:concat - Concatenates two or more xs:anyAtomicType arguments cast to
> xs:string.
> fn:string-join - Returns the xs:string produced by concatenating a sequence
> of xs:strings using an optional separator.
> fn:substring - Returns the xs:string located at a specified place within an
> argument xs:string.
> fn:string-length - Returns the length of the argument.
> fn:upper-case - Returns the upper-cased value of the argument.
> fn:lower-case - Returns the lower-cased value of the argument.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
