Hi Preston, I think that that code was there to ensure that sequences of atomic values get serialized with a space in-between the values. Is it really not needed anymore?
Till On Nov 16, 2012, at 9:31 AM, [email protected] wrote: > Author: prestonc > Date: Fri Nov 16 17:31:48 2012 > New Revision: 1410501 > > URL: http://svn.apache.org/viewvc?rev=1410501&view=rev > Log: > Removing code at adds an extra space to the output. > > Modified: > > incubator/vxquery/trunk/vxquery/vxquery-core/src/main/java/org/apache/vxquery/serializer/XMLSerializer.java > > Modified: > incubator/vxquery/trunk/vxquery/vxquery-core/src/main/java/org/apache/vxquery/serializer/XMLSerializer.java > URL: > http://svn.apache.org/viewvc/incubator/vxquery/trunk/vxquery/vxquery-core/src/main/java/org/apache/vxquery/serializer/XMLSerializer.java?rev=1410501&r1=1410500&r2=1410501&view=diff > ============================================================================== > --- > incubator/vxquery/trunk/vxquery/vxquery-core/src/main/java/org/apache/vxquery/serializer/XMLSerializer.java > (original) > +++ > incubator/vxquery/trunk/vxquery/vxquery-core/src/main/java/org/apache/vxquery/serializer/XMLSerializer.java > Fri Nov 16 17:31:48 2012 > @@ -64,8 +64,6 @@ public class XMLSerializer implements IP > private DataOutput dOut = abvs.getDataOutput(); > private CastToStringOperation castToString = new CastToStringOperation(); > > - private boolean lastWasAtomic = false; > - > public XMLSerializer() { > pp = PointablePoolFactory.INSTANCE.createPointablePool(); > } > @@ -83,15 +81,6 @@ public class XMLSerializer implements IP > > private void printTaggedValuePointable(PrintStream ps, > TaggedValuePointable tvp) { > byte tag = tvp.getTag(); > - if (ValueTag.isAtomic(tag)) { > - if (lastWasAtomic) { > - ps.append(' '); > - } else { > - lastWasAtomic = true; > - } > - } else { > - lastWasAtomic = false; > - } > switch ((int) tag) { > case ValueTag.XS_ANY_URI_TAG: > printString(ps, tvp); > >
