Taras,
On Tue, Mar 8, 2011 at 6:00 PM, Taras <ox...@oxdef.info> wrote:
> Andres,
>
> 1. falsePositiveManager is removed
> 2. Added option for smtp server port, so it is validated as int in
> the 'option' class
> 3. Added more text to the description =)
> 4. Changed W3AF => w3af (by the way, why we use such notation?)
Because I like it :)
> 5. Changed doc string for the class
> 6. Committed to the trunk
Great! I tweeted about it and it seems that a couple of guys liked it :)
>> > NB! Plugin uses experimental false-positive manager to prevent sending a
>> > lot of trash to your email. But I can switch off this feature.
>>
>> For now the falsePositive thing is too experimental, but the
>> emailReport.py plugin is very nice, so I would recommend you remove
>> the falsePositive manager from it and commit it to the trunk. Here are
>> some other comments about the plugin:
>>
>> - self.smtpServer, self.smtpPort = smtpServer.split(":") , I would
>> validate there that the smtpPort is really an int, and not in server =
>> smtplib.SMTP(self.smtpServer, int(self.smtpPort))
>>
>> - getLongDesc() output should be LONG :) Please see the other outputs,
>> where we describe the parameters, etc.
>>
>> - msg['Subject'] = 'W3AF report on %s' % self.targets[0] , I would
>> change that from "W3AF" to "w3af"
>>
>> - '''Email reporter class.''' , please remember that this is shown in
>> the consoleUi when a user lists all plugins. It should be more
>> descriptive, something like "Email report to specified addresses".
>>
>> > What do you think about it? Any comments are welcome!
>>
>> I haven't been able to run pylint over the plugin, does it pass
>> without any errors?
> Pylint shows mostly name convention warnings. May be we make config for
> PyLint to test code against our code convention?
No need to respect pylint at 100% , I just wanted to make sure it
didn't had any errors,
Regards,
>>
>> > [0]
>> > http://w3af.svn.sourceforge.net/viewvc/w3af/branches/taras/plugins/output/emailReport.py
>>
>> Great stuff! :)
>>
>
> --
> Taras
> http://oxdef.info
> ----
> "Software is like sex: it's better when it's free." - Linus Torvalds
>
>
>
--
Andrés Riancho
Director of Web Security at Rapid7 LLC
Founder at Bonsai Information Security
Project Leader at w3af
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
W3af-develop mailing list
W3af-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/w3af-develop
