Guerrino,
On Mon, Jun 4, 2012 at 6:40 AM, guerrino.dima...@gmail.com
<guerrino.dima...@gmail.com> wrote:
> Hi everybody. I'd like to learn more and more about w3af programming. The
> best way ,of course, is the "hands on" method. Totally based on zone-h
> plugin i created another one called netcraft.
That's a great way to learn! :)
> Hope someone will find it useful.
Sure mate, here is my review:
* File header missing
* Unused imports:
- import core.data.kb.vuln as vuln
- import core.data.constants.severity as severity
* Just to be sure, specify the protocol here:
- netcraft_url_str = 'toolbar.netcraft.com/site_report?url=' + target_domain
* In this line, there is a " " (space) missing in order to make the
identation correct:
- response = self._urlOpener.GET( netcraft_url )
* I would expect the "_parse_netcraft_result" to parse all results,
extract the information and add that to the info object. Having the
user "go to netcraft site for more info" is not as useful.
* Please try to respect the 90 columns per line limit.
All looks good, seems that the next version will be much better :D
Regards,
> guerrino
>
>
> p.s.
> please drop me a line if a missed something... (after all i'ts my first
> post)
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> W3af-develop mailing list
> W3af-develop@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/w3af-develop
>
--
Andrés Riancho
Project Leader at w3af - http://w3af.org/
Web Application Attack and Audit Framework
Twitter: @w3af
GPG: 0x93C344F3
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
W3af-develop mailing list
W3af-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/w3af-develop
