On 12/02/2013 01:32 PM, Chad Versace wrote:
On 12/02/2013 04:16 AM, Shazia Rahman wrote:
Get these errors while building waffle after syncing latest code from git repo.
[ 90%] Built target waffle_static
[ 91%] Building C object
src/waffle/CMakeFiles/wcore_attrib_list_unittest.dir/core/wcore_attrib_list_unittest.c.o
make[2]: *** No rule to make target
`third_party/cmocka/build/src/libcmocka.so', needed by
`tests/wcore_attrib_list_unittest'. Stop.
make[1]: *** [src/waffle/CMakeFiles/wcore_attrib_list_unittest.dir/all] Error 2
make: *** [all] Error 2
Cloned the latest source using giit clone
git://people.freedesktop.org/~chadversary/waffle
Shazia, I believe the issue may be fixed by the commit below. Please purge your
build
directory, rerun cmake, and let me know if the issue is fixed for you. If it's
not fixed,
then give me the exact git hash you are using.
commit c56327e97b21fb53dc6e7da7f4ff384427fff73d
Author: Chad Versace <[email protected]>
Date: Sun Dec 1 21:55:44 2013 -0800
cmake: Don't build unittests when waffle_build_tests=0
Return early from add_unittest() if waffle_build_tests=0, making the
function a no-op.
Signed-off-by: Chad Versace <[email protected]>
Shazi,
With Paul Berry's assistance, I've reproduced the build failure on the above
commit.
The failure occurs when using CMake's "Unix Makefiles" generator, the default
generator (cmake
-G"Unix Makefiles"). The failure does not occur when using CMake's Ninja
generator (cmake -GNinja),
which is what I normally use for my builds.
I CC'd you on a patch that should fix the failure. I'll wait for either your or
Paul's
Tested-by before committing.
_______________________________________________
waffle mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/waffle
