Giel van Schijndel schreef: > Gerard Krol schreef: > >> I know I only posted it only 4 days ago, but I really sleep better >> when I know my patches have been applied. Could someone apply this >> patch? I even polished it a little bit more. >> >> This patch prevents a segfault when designing a droid on amd64. >> Reproduce: on amd64, go to the droid design screen and design a >> construction droid. Then hover your mouse over another system, like >> sensor or command. >> >> Regards, >> >> Gerard >> > Applied in r750. > > Hope you did sleep well enough those 4 days? Anyway I'm hoping you'll > sleep better now again ;-) . Sorry, I haven't looked at your latest patch until after committing the previous one.
Anyway your latest version looks a bit ugly to me. There's an awfully large amount of casts in there, not to mention that your insertion of that switch statement uses the variable `type` which at that point isn't yet initialized => undefined behaviour. Plus I'm not quite sure what the difference is between the first and second patch. Not meaning to offend you though. -- Giel
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
