Am Freitag, 16. Februar 2007 schrieb Giel van Schijndel: > Dennis Schridde schreef: > > Author: devurandom > > Date: Thu Feb 15 16:36:25 2007 > > New Revision: 757 > > > > URL: http://svn.gna.org/viewcvs/warzone?rev=757&view=rev > > Log: > > Port of r756 (buildsystem/installation improvements) > > > > Modified: > > trunk/Makefile.am > > trunk/autopackage/default.apspec.in > > trunk/configure.ac > > trunk/data/Makefile.am > > trunk/nsis/Makefile.am > > trunk/nsis/Makefile.raw > > trunk/win32/Makefile.am > > The changes you've made here to trunk/nsis/Makefile.raw (changing the > define params from "/Dvar=val" to -Dvar="val") invalidate the command > line on windows. Simply reverting those changes make it work again. > > So, my question, are you sure these changes are necessary for something? I wouldn't have done it if it wouldn't be necessary... makensis wants -D on Linux and /D on Windows, apparently... I have no idea why the NSIS team decided on that, it's very ugly IMHO... I thought, if it would read -D on Linux, it might take the same on Windows.
I filed a bug on NSIS: http://sourceforge.net/tracker/index.php?func=detail&aid=1661503&group_id=22049&atid=373085 Till this is fixed, how do we want to solve it? Add a NSISCL=/ define for Windows and NSISCL=- for Linux and write $(MAKENSIS) $(NSISCL)Dvar=val ? Or would it be ok that one of us sets the Makefile to ignore and changes it locally? --Dennis
pgpWH6vu9RKeF.pgp
Description: PGP signature
_______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
