On Mon, May 25, 2009 at 10:03:09AM +0200, Dennis Schridde wrote: > Am Sonntag, 24. Mai 2009 23:40:41 schrieb muggen...@users.sourceforge.net: >> Revision: 7539 >> >> http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7539&view=rev >> Author: muggenhor >> Date: 2009-05-24 21:40:41 +0000 (Sun, 24 May 2009) >> >> Log Message: >> ----------- >> Exceptionhandler: Remove signal descriptions for signals that are either >> non fatal or simply not handled by our signal handler > Are you trying to save size in the executable? > > In other words: What is the sense of this? Did those strings harm someone? Is > it bad to have a generic signal-to-string method? > > Suggestion: Revert
Some of those signals simply don't exist on some other systems, e.g. FreeBSD. In order to get it to compile on FreeBSD I would have had to add about 3 #ifdef statements. As for a "generic" signal-to-string method, considering that it's not platform agnostic the "generic" part goes out the window. In addition to that, we simply don't need a way of translating all signals to strings since we only use that translation method in the crash handler, and not all signals are fatal. -- Giel
signature.asc
Description: Digital signature
_______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
