Branch: refs/heads/master
  Home:   https://github.com/Warzone2100/warzone2100
  Commit: 3c435335bcf57e03a86ddee3fc9fe13b1fa67175
      
https://github.com/Warzone2100/warzone2100/commit/3c435335bcf57e03a86ddee3fc9fe13b1fa67175
  Author: Thiago Barcala <thiago.barc...@gmail.com>
  Date:   2020-10-24 (Sat, 24 Oct 2020)

  Changed paths:
    M src/configuration.cpp
    M src/keybind.cpp
    M src/keybind.h
    M src/multiplay.h

  Log Message:
  -----------
  Delete dead code for message macros

Message macros is a very old feature that allowed players to define
message macros. To define a macro, the player would type the message in
the message input, then press CTRL+F[1..5]. To use the defined macro the
player would open the message input and press F[1..5]. The message
defined in the macro would be copied to the message input.

This feature doesn't work anymore since the commit
e252b9a460829f03ea0557330de1789fd5f4ee30, which introduced the chat box.
What causes it not to work anymore is:
1. The code that handles macro's usage is not reachable anymore. The
aforementioned commit removed the call to `kf_SendTextMessage` in
display.cpp. That call was responsible for processing the macro-related
key presses. This function is now called `kf_SendGlobalMessage` and is
accessible only through the user-defined key mapping for sending
messages globally.
2. The message typed in the chat box is not copied to the global
variable `sTextToSend`, and vice-versa.




_______________________________________________
Warzone2100-commits mailing list
Warzone2100-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/warzone2100-commits

Reply via email to