#4748: improve Windows installer
-------------------------------------------------+-------------------------
Reporter: Forgon | Owner:
Type: patch (an actual patch, not a | Status: new
request for one) | Milestone:
Priority: normal | unspecified
Component: other | Version:
Keywords: | git/master
Blocking: | Blocked By:
| Operating System: All
| /Non-Specific
-------------------------------------------------+-------------------------
The Windows Portable installer placed downloaded videos in the fonts
subdirectory of the installation directory (read
[https://forums.wz2100.net/viewtopic.php?f=6&t=12745 this forum thread]).
The problem was caused by the instruction 'SetOutPath', which sets the
output path for files (as documented
[http://web.archive.org/web/20180102121259/http://nsis.sourceforge.net/Docs/Chapter4.html
here]). After executing 'SetOutPath "$INSTDIR\fonts"', no new output path
was specified for the video installation section group, so that the file
'sequences.wz' which contains campaign videos ended up in the './fonts'
directory.
The Windows installer also created a directory for mods in the
installation directory, which contained a few subfolders. This was
inconsistent with placing mods in the configuration folder and has thus
been abolished.
Incidentally, I noticed that there is an unused 'mods' directory inside
'./data/base', which even contains a file named 'thisDirectoryIsEmpty'.
Should we really keep it?
I also removed two deprecated files, both of which were introduced in
`
commit ae921a9ca922434ce0ad445d1dfc52e36059ff39
Author: Vincent Lejeune <vljn....@gmail.com>
Date: Sat Jul 15 18:10:00 2017 +0200
Improve CMakeLists.txt.
* Use target and properties.
* Relies on define/includes dependencies propagation.
* Use CPack for install.
'
That patch should be double-checked since, apart from its whitespace
errors, it might have other faults.
It had created the unused file './pkg/nsis/NSIS.templates.in.', whose
contents were not updated (except in error as part of #4664) and which was
altogether unused. It also had the same encoding problems Cyp recently
fixed for the file './pkg/nsis/warzone2100.nsi' in
d27a7ad27b8720c6e1e451f656123a736b8d7193.
The purpose of './pkg/nsis/NSIS.definitions.in' was more mysterious, yet
its outdated contents (such as defining 'PACKAGE_VERSION' as '3.2') led me
to choose that it too should be removed.
--
Ticket URL: <http://developer.wz2100.net/ticket/4748>
Warzone 2100 Trac <http://developer.wz2100.net/>
The Warzone 2100 Project
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Warzone2100-project mailing list
Warzone2100-project@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/warzone2100-project
