[ 
https://issues.apache.org/jira/browse/WAVE-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051703#comment-13051703
 ] 

David Hearnden commented on WAVE-285:
-------------------------------------

Yes, adding overflow:hidden or overflow:auto will make the target element's 
flow include its floated contents (the width:100% is unnecessary). This trick 
is already used in a few places already in the UI - I thought blips already had 
that on them, or the .editor or .doc classes.  If it's missing, then yes, it 
needs to be added.

Were it not for efficiency concerns, I'd recommend having:

  * {
    overflow:hidden
  }

on the whole page, because that's a far more useful behaviour than CSS's 
default.

> Editor should insert a <br style="clear: both"> at the end so it grows with 
> floated elements (focus issue)
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: WAVE-285
>                 URL: https://issues.apache.org/jira/browse/WAVE-285
>             Project: Wave
>          Issue Type: Bug
>          Components: Extentions, Web Client
>            Reporter: Thomas Broyer
>            Priority: Minor
>
> When a doodad generates floated elements (e.g. style="float: left"), the 
> editor surface doesn't grow with it. As a result, when clicking on the part 
> on the side of the floated element, you might click outside the editor, and 
> it thus fails to give it focus.
> Adding a <br style="clear: both"> or similar between the body element's </ul> 
> and the ContentDocElement's </div> would fix it.
> Currently, the document <body><line/>Foo</body> is rendered as:
> <div>
>   <ul>
>     <div>Foo</div>
>   </ul>
> </div>
> It should be made either:
> <div>
>   <ul>
>     <div>Foo</div>
>   </ul>
>   <br style="clear: both">
> </div>
> or (wrapping the current structure into an additional <div>, so it can be 
> made the "autoAppendContainer")
> <div>
>   <div>
>     <ul>
>       <div>Foo</div>
>     </ul>
>   </div>
>   <br style="clear: both">
> </div>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to