[
https://issues.apache.org/jira/browse/WAVE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189373#comment-13189373
]
[email protected] commented on WAVE-325:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3508/#review4481
-----------------------------------------------------------
src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java
<https://reviews.apache.org/r/3508/#comment10049>
The parameters for matcheFunction class are per call to
createFilterWaveletsFunction, so it should be created inside this method I
think.
src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java
<https://reviews.apache.org/r/3508/#comment10050>
Done
src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java
<https://reviews.apache.org/r/3508/#comment10051>
http://guava-libraries.googlecode.com/svn/trunk/javadoc/com/google/common/collect/MapMaker.html
It means that the values in the map are computed per each key on the first
get() and then cached.
src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java
<https://reviews.apache.org/r/3508/#comment10052>
Done
src/org/waveprotocol/box/server/waveserver/QueryHelper.java
<https://reviews.apache.org/r/3508/#comment10056>
Done
src/org/waveprotocol/box/server/waveserver/QueryHelper.java
<https://reviews.apache.org/r/3508/#comment10053>
The creator computation is done at line 127. Basically we look for
ConversationalRootWavelet and take the creator from there. But if some reason
there was no such wavelet - we just use this unknown creator. I am not sure how
exceptional this case, but it provides more stability for the comparison.
src/org/waveprotocol/box/server/waveserver/QueryHelper.java
<https://reviews.apache.org/r/3508/#comment10054>
Done
src/org/waveprotocol/box/server/waveserver/QueryHelper.java
<https://reviews.apache.org/r/3508/#comment10055>
Done
src/org/waveprotocol/box/server/waveserver/QueryHelper.java
<https://reviews.apache.org/r/3508/#comment10057>
Done
test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java
<https://reviews.apache.org/r/3508/#comment10058>
Done
- Yuri
On 2012-01-19 20:49:33, Yuri Zelikov wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3508/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-19 20:49:33)
bq.
bq.
bq. Review request for wave, Michael MacFadden and Lennard de Rijk.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The goal of this patch is to decouple the search implementation
(SearchProvider) from the waves accessing logic (WaveMap). It should allow for
alternative implementations of search providers - not dependent on concrete
implementation of waves loading and access. The biggest problem with current
implementation is that it requires to load all waves into memory on the server
start up. An alternative (not memory based) search implementation would allow
to load the waves lazily and evict later.
bq.
bq.
bq. This addresses bug WAVE-325.
bq. https://issues.apache.org/jira/browse/WAVE-325
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java
PRE-CREATION
bq.
src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java
PRE-CREATION
bq. src/org/waveprotocol/box/server/waveserver/QueryHelper.java PRE-CREATION
bq. src/org/waveprotocol/box/server/waveserver/TokenQueryType.java
PRE-CREATION
bq. src/org/waveprotocol/box/server/waveserver/Wave.java PRE-CREATION
bq. src/org/waveprotocol/box/server/waveserver/WaveMap.java 42eb62b
bq. src/org/waveprotocol/box/server/waveserver/WaveServerModule.java 4892dc3
bq. src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java
ca05900
bq.
test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java
PRE-CREATION
bq.
test/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriberTest.java
PRE-CREATION
bq. test/org/waveprotocol/box/server/waveserver/WaveDigesterTest.java
9a49ab2
bq. test/org/waveprotocol/box/server/waveserver/WaveMapTest.java 17ba0df
bq.
bq. Diff: https://reviews.apache.org/r/3508/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Yuri
bq.
bq.
> Decouple the search implementation from the waves persistence logic.
> --------------------------------------------------------------------
>
> Key: WAVE-325
> URL: https://issues.apache.org/jira/browse/WAVE-325
> Project: Wave
> Issue Type: Improvement
> Components: Server
> Reporter: Yuri Zelikov
> Assignee: Yuri Zelikov
>
> The goal of this patch is to decouple the search implementation
> (SearchProvider) from the waves accessing logic (WaveMap). It should allow
> for alternative implementations of search providers - not dependent on
> concrete implementation of waves loading and access. The biggest problem with
> current implementation is that it requires to load all waves into memory on
> the server start up. An alternative (not memory based) search implementation
> would allow to load the waves lazily and evict later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
