[
https://issues.apache.org/jira/browse/WAVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208586#comment-13208586
]
[email protected] commented on WAVE-317:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3882/#review5128
-----------------------------------------------------------
"a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java"
<https://reviews.apache.org/r/3882/#comment11230>
Can we extract this code that handles building of participants into
separate method?
Also it would be great to add a unit tests for this new method.
"a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java"
<https://reviews.apache.org/r/3882/#comment11231>
I think it would be better first to validate all participants and add them
all only in case all addresses are valid - kind of "all or nothing" transaction.
- Yuri
On 2012-02-13 22:56:00, rocklund wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3882/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-13 22:56:00)
bq.
bq.
bq. Review request for wave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented as suggested in the jira-issue as a client side implementation
in ParticipantController.java. I selected the separator for the multiple
participant list to be semi-colon(;).
bq.
bq.
bq. This addresses bug wave-317.
bq. https://issues.apache.org/jira/browse/wave-317
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" ec9e25a
bq.
bq. Diff: https://reviews.apache.org/r/3882/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Compiled and run.
bq.
bq. * Tested to add single as well as multiple participants
bq. * Tested to add participants both with and without @localhost
bq. * Tested to add invalid participants
bq.
bq.
bq. Thanks,
bq.
bq. rocklund
bq.
bq.
> Allow adding (copy/pasting) multiple participants into a wave
> -------------------------------------------------------------
>
> Key: WAVE-317
> URL: https://issues.apache.org/jira/browse/WAVE-317
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Yuri Zelikov
> Priority: Minor
> Labels: StarterProject
>
> I think it would be nice to allow to paste/enter multiple participant ids
> separated by comma into the "add participant" dialog box. The list will be
> parsed/validated by the client and interpreted like it the user added these
> participants one by one. This way it would be easier to create waves with
> multiple participants.
> The code is handled in ParticipantController.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
