[
https://issues.apache.org/jira/browse/WAVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242171#comment-13242171
]
[email protected] commented on WAVE-319:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3960/#review6572
-----------------------------------------------------------
Thanks, great work!
Basically the patch is good. But I think it would be better to use regular
JUnit instead of GWT one. The issue with JSON parsing can be solved by
encapsulating the parsing logic into separate class that can be injected into
GadgetInfoProviderImpl - for example
public interface GadgetInfoParser {
public List<GadgetInfo> parseGadgetInfoJson(String json);
}
Then we can have two implementations of this interface.
For use in application:
GadgetInfoProviderImpl gadgetInfoProvider = new GadgetInfoProviderImpl(new
GwtGadgetInfoParser());
For JUnit we can just inject a mock implementation to return the gadget infos
or use some server side implementation of JSON parser.
- Yuri
On 2012-03-24 13:30:50, rocklund wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3960/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-24 13:30:50)
bq.
bq.
bq. Review request for wave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. * Added more gadgets to the gadget list
bq. * Made the gadget list scrollable and filterable through a text box and a
drop down box for categories.
bq. * The filtering looks at both the name of the gadget and its description.
Author could also be added as a searchable property (?)
bq. * Filter the result directly in the scrollable gadget list
bq. * Marking the top filtered search as selected with gray background and
made it possible to choose that gadget by pressing enter
bq. * Change the default focus to the filter box to allow the user to quickly
select a gadget from the list by filter it out and pressing enter
bq.
bq.
bq. This addresses bug wave-319.
bq. https://issues.apache.org/jira/browse/wave-319
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. jsongadgets.json PRE-CREATION
bq. src/org/waveprotocol/box/server/ServerMain.java 13a2d55
bq. src/org/waveprotocol/box/server/persistence/file/FileUtils.java 538e6e3
bq. src/org/waveprotocol/box/server/rpc/GadgetProviderServlet.java
PRE-CREATION
bq. src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java
3a470e0
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProvider.java
PRE-CREATION
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProviderImpl.java
PRE-CREATION
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.java
97611b4
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.ui.xml
c8b7a81
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
ccbcdae
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml
cc6b73e
bq. src/org/waveprotocol/wave/client/widget/popup/CenterPopupPositioner.java
555f32e
bq. src/org/waveprotocol/wave/client/widget/popup/PositionUtil.java 5e3bab4
bq.
test/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoProviderTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3960/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally.
bq. Successfully run all junit test (Except
PerUserWaveViewSubscriberTest::testGetPerUserWaveView and
WaveServerTest::testWaveletNotification that fails even before this patch)
bq. Tested all included gadgets
bq.
bq.
bq. Thanks,
bq.
bq. rocklund
bq.
bq.
> Improve the "Add gadget" popup
> -------------------------------
>
> Key: WAVE-319
> URL: https://issues.apache.org/jira/browse/WAVE-319
> Project: Wave
> Issue Type: Improvement
> Components: Web Client
> Reporter: Yuri Zelikov
> Assignee: Olof
> Priority: Minor
> Labels: StarterProject
>
> Improve the "Add gadget" popup. Currently it contains only a handful of
> gadgets. Add more gadget definitions, make the panel scrollable, add ability
> to filter the gadgets list and or add suggestion box -
> http://gwt.google.com/samples/Showcase/Showcase.html#!CwSuggestBox
> The gadget definitions can be taken from http://goo.gl/nEem2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
