----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3515 -----------------------------------------------------------
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java <https://reviews.apache.org/r/2932/#comment7852> The line is too long - longer than 100 chars which is the standard for WIAB. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java <https://reviews.apache.org/r/2932/#comment7859> Line is too long. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java <https://reviews.apache.org/r/2932/#comment7856> Seems like the <code></code> tags here are not needed,{@link} already formats it. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java <https://reviews.apache.org/r/2932/#comment7854> No need to specify that methods solve issue. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java <https://reviews.apache.org/r/2932/#comment7855> Probably it would be better just to remove @param and @return since they add no details. /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java <https://reviews.apache.org/r/2932/#comment7849> How about returning the Collections.EmptyMap() here? I mean: Map<String, String[]> emptyMap = Collections.emptyMap(); when(req.getParameterMap()).thenReturn(emptyMap); - Yuri On 2011-11-25 18:23:15, Antonio Bello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2932/ > ----------------------------------------------------------- > > (Updated 2011-11-25 18:23:15) > > > Review request for wave. > > > Summary > ------- > > This patch solves the problem in my case. > > I'm running ubuntu x64, and experienced the same problem. > > What I did is simply change the parameter type passed to the thenReturn() > method: > * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest > * replace ImmutableMap.of() with new Hashtable<String, String[]>() in > DataApiServletTest > > > This addresses bug WAVE-298. > https://issues.apache.org/jira/browse/WAVE-298 > > > Diffs > ----- > > /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java > 1206126 > /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java > 1206126 > > Diff: https://reviews.apache.org/r/2932/diff > > > Testing > ------- > > ant test runs with no errors on ubuntu x64 10.04 > > > Thanks, > > Antonio > >
