----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3754/ -----------------------------------------------------------
Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. Summary ------- It seems like Jetty drops connection with client due to idle timeouts. In the waveinabox.net log I could see a lot of messages like this: "WARNING: Websocket is not connected" Probably it would be better set idle timeout time to infinity to avoid disconnects. Diffs ----- src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 810f19a src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 651bf97 Diff: https://reviews.apache.org/r/3754/diff Testing ------- Applied the patch locally and ensured that there are no disconnections due to timeouts. Thanks, Yuri
