> On 2012-01-27 10:19:42, Yuri Zelikov wrote: > > Can we maybe restructure the patch a bit -> instead of taking Walkaround > > source into WIAB - maybe we just need to add Walkaround code as a jar to > > WIAB dependencies?
I think it is not necessary for several reasons: 1. Walkaround code heavily depends of GAE libraires. So GAE libraires must be included such way again. 2. Import uses from Walkaround only small part, that subscribes request to GWave. It is well localized in a few source code. 3. When GWave will stop, this code simply would not be necessary. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review4647 ----------------------------------------------------------- On 2012-02-07 12:43:00, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > ----------------------------------------------------------- > > (Updated 2012-02-07 12:43:00) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > The implementation is very raw, due to time constraints. > Import accesses special service on the Wiab. > Authorization on import service are not implemented now. > Imports of attachments not yet implemented. > Also, there is no generation of wave Id's for import into a non-empty store, > and from different domains. > Instructions for use enclosed in the file README.import. > > > Diffs > ----- > > ./README.import PRE-CREATION > ./build.properties 1240026 > ./build.xml 1240026 > ./run-export.sh PRE-CREATION > ./run-import.sh PRE-CREATION > ./server-config.xml 1240026 > ./src/org/waveprotocol/box/server/CoreSettings.java 1240026 > ./src/org/waveprotocol/box/server/ServerMain.java 1240026 > ./src/org/waveprotocol/box/server/util/testing/TestingConstants.java > 1240026 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveExport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveImport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotApi.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java > PRE-CREATION > > ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java > PRE-CREATION > ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > PRE-CREATION > ./third_party/runtime/google_client/COPYING PRE-CREATION > ./third_party/runtime/google_client/google-api-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google_client/google-http-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google_client/google-oauth-client-1.5.0-beta.jar > UNKNOWN > > Diff: https://reviews.apache.org/r/3564/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
