----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3801/#review4923 -----------------------------------------------------------
Committed as r1242062 - Yuri On 2012-02-08 18:50:43, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3801/ > ----------------------------------------------------------- > > (Updated 2012-02-08 18:50:43) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Part of the SSL patch changed the IO type from NIO to BIO to solve an issue > with the SSL handshake timeout using TLS authentication with the default > browser on Android ICS. > > 1) The Socket.IO Java interface appears to crash the jetty worker threads > when this is the case > 2) Chrome for Android (ICS+ only) has just been released (is intended to > replace default browser) and doesn't have the timeout issue. > > > Diffs > ----- > > /src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 1241658 > > Diff: https://reviews.apache.org/r/3801/diff > > > Testing > ------- > > Compiled and run locally when applied against the current trunk. > > Without patch connections fail, with patch they work again. > > > Thanks, > > Ali > >
