----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3810/#review4924 -----------------------------------------------------------
Ship it! LGTM Committed as r1242063 - Yuri On 2012-02-08 19:37:25, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3810/ > ----------------------------------------------------------- > > (Updated 2012-02-08 19:37:25) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > NB: Apply this patch _after_ r.3801 (Fix general Socket.IO breakage). > > This patch updates the URL + SHA in the README.google (should it still be > called README.google though?) > It also updates the 2 jar files socketio-core-0.1-SNAPSHOT-*.jar (which are > built from the referenced commit). > > The update to socketio forces the 'secure' option if the page url begins with > a 'https', and forces the request port to be the same as the one specified in > the url. (443 etc. are implied). > > > Diffs > ----- > > /third_party/runtime/socketio/README.google 1241658 > > Diff: https://reviews.apache.org/r/3810/diff > > > Testing > ------- > > Works here. :) > > > Thanks, > > Ali > >
