I am not a developer. 

How can I remove myself from this list?

--

Thank you

michael earl @ michael earl .com       (888) 866-7607 North America Direct, 
toll-free voice, and fax       (760) 999-8068 International Direct, voice, and 
fax

All criterions fully governing this message and implied relationship may be 
found at TheFinePrint.MediaManager.ME


Sent wirelessly from my BlackBerry device

-----Original Message-----
From: [email protected]
Date: Sat, 11 Feb 2012 15:20:32 
To: <[email protected]>; Ali Lown<[email protected]>; Michael 
MacFadden<[email protected]>
Reply-To: [email protected]
Cc: Yuri Zelikov<[email protected]>; wave<[email protected]>
Subject: Re: Review Request: Fixes issue WAVE-333 - Welcome wave is not 
displayed
 after registration


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3864/#review5022
-----------------------------------------------------------

Ship it!


Tested. LGTM

- vjrj


On 2012-02-11 13:30:37, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3864/
> -----------------------------------------------------------
> 
> (Updated 2012-02-11 13:30:37)
> 
> 
> Review request for wave, Michael MacFadden, vjrj, and Ali Lown.
> 
> 
> Summary
> -------
> 
> Fixes issue WAVE-333 - Welcome wave is not displayed after registration. The 
> problem was with the use of method waveMap.lookupWavelet(waveId) which 
> returns only wavelets that were loaded during the server start. 
> 
> 
> This addresses bug WAVE-333.
>     https://issues.apache.org/jira/browse/WAVE-333
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java 
> ec446a3 
>   src/org/waveprotocol/box/server/waveserver/Wave.java de13222 
>   src/org/waveprotocol/box/server/waveserver/WaveMap.java 36224ec 
> 
> Diff: https://reviews.apache.org/r/3864/diff
> 
> 
> Testing
> -------
> 
> Registered a new user and checked that the welcome wave is displayed.
> 
> 
> Thanks,
> 
> Yuri
> 
>


Reply via email to