> On 2012-02-14 20:06:25, Yuri Zelikov wrote: > > The last few comments. > > The only issue - for some reason I can't access the imported waves. For > > example my GWave user is [email protected]. So, after importing the > > waves (with -i option) I registered vega113 in my local environment and > > expected to see the waves in the inbox - but there were non. I also notices > > that the import message said that "imported count" was 0 but "appended > > count" was 1. > >
Yuri, what parameters you specified to import? Is parameter domain same as domain of Wiab server? > On 2012-02-14 20:06:25, Yuri Zelikov wrote: > > ./README.import, line 17 > > <https://reviews.apache.org/r/3564/diff/13/?file=74659#file74659line17> > > > > Probably need to mention to run the dist-import ant target first. dist-import invoked on default ant target > On 2012-02-14 20:06:25, Yuri Zelikov wrote: > > ./README.import, line 25 > > <https://reviews.apache.org/r/3564/diff/13/?file=74659#file74659line25> > > > > I am not sure if this is cygwin related issue only, or happens also for > > real Linux users, but I need to prepend the "!" in wave id with "\", > > otherwise it gives me some shell error: "No event found" It is a special character for Unix shell. > On 2012-02-14 20:06:25, Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java, line 142 > > <https://reviews.apache.org/r/3564/diff/13/?file=74669#file74669line142> > > > > Probably need to add here some log message. I don't think so. That is not error and does not apply to debug of the server. And such messages may bee very numerous. > On 2012-02-14 20:06:25, Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java, line 145 > > <https://reviews.apache.org/r/3564/diff/13/?file=74669#file74669line145> > > > > Does it mean that the outer loop executes only once? If so, can we > > remove it? Yes. > On 2012-02-14 20:06:25, Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/waveimport/WaveExport.java, line 204 > > <https://reviews.apache.org/r/3564/diff/13/?file=74670#file74670line204> > > > > Can we extract this "000000" format into constant? Yes. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3564/#review5087 ----------------------------------------------------------- On 2012-02-13 10:41:09, Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3564/ > ----------------------------------------------------------- > > (Updated 2012-02-13 10:41:09) > > > Review request for wave and Yuri Zelikov. > > > Summary > ------- > > Exports waves from GWave to files, and imports them to Wiab by two command > line utilities. > Import accesses special service on the Wiab. > Imports of attachments not yet implemented. > Also, there is no generation of wave Id's for import into a non-empty store, > and from different domains. > Instructions for use enclosed in the file README.import. > > > Diffs > ----- > > ./.classpath 1243425 > ./README.import PRE-CREATION > ./build.properties 1243425 > ./build.xml 1243425 > ./run-export.sh PRE-CREATION > ./run-import.sh PRE-CREATION > ./server-config.xml 1243425 > ./server.config.example 1243425 > ./src/org/waveprotocol/box/server/CoreSettings.java 1243425 > ./src/org/waveprotocol/box/server/ServerMain.java 1243425 > ./src/org/waveprotocol/box/server/util/testing/TestingConstants.java > 1243425 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveExport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/WaveImport.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotApi.java PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java > PRE-CREATION > > ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java > PRE-CREATION > ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java > PRE-CREATION > ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > PRE-CREATION > ./third_party/runtime/google-api-client/COPYING PRE-CREATION > ./third_party/runtime/google-api-client/README PRE-CREATION > ./third_party/runtime/google-api-client/google-api-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google-api-client/google-http-client-1.5.0-beta.jar > UNKNOWN > ./third_party/runtime/google-api-client/google-oauth-client-1.5.0-beta.jar > UNKNOWN > > Diff: https://reviews.apache.org/r/3564/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
