----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4829/#review7076 -----------------------------------------------------------
Are the changes to the SearchServlet here going to have any issues with the Lucene based search modifications also under review? - Ali On 2012-04-20 12:59:24, Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4829/ > ----------------------------------------------------------- > > (Updated 2012-04-20 12:59:24) > > > Review request for wave, Michael MacFadden and Ali Lown. > > > Summary > ------- > > Adds notifier servlet that serves search digests for users in JSON format - > to allow easier integration with "Notifier" Chrome extension. > > > Diffs > ----- > > src/org/waveprotocol/box/server/ServerMain.java 5910c88 > src/org/waveprotocol/box/server/rpc/AbstractSearchServlet.java PRE-CREATION > src/org/waveprotocol/box/server/rpc/NotificationServlet.java PRE-CREATION > src/org/waveprotocol/box/server/rpc/SearchServlet.java 7302b85 > > Diff: https://reviews.apache.org/r/4829/diff > > > Testing > ------- > > Tested that /notification/ correctly returns the user digests and search > still works. > > > Thanks, > > Yuri > >
