----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4924/ -----------------------------------------------------------
(Updated 2012-04-28 14:47:09.102439) Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk. Changes ------- Addressed comment by Ali. Summary ------- Makes the threads count for executors that handle wavelet loading and lookup configurable. That also should reduce the memory footprint as the wavelet loading executor will be reused by all waveles instead of creating a new one per wavelet. Diffs (updated) ----- server-config.xml d2c1bc7 server.config.example 7eb075f src/org/waveprotocol/box/server/CoreSettings.java a28ec66 src/org/waveprotocol/box/server/ServerMain.java 03d04ab src/org/waveprotocol/box/server/ServerModule.java 4debe3b src/org/waveprotocol/box/server/waveserver/LocalWaveletContainerImpl.java 74f7590 src/org/waveprotocol/box/server/waveserver/LookupExecutor.java PRE-CREATION src/org/waveprotocol/box/server/waveserver/RemoteWaveletContainerImpl.java ceb0862 src/org/waveprotocol/box/server/waveserver/WaveMap.java a0d72d6 src/org/waveprotocol/box/server/waveserver/WaveServerModule.java eb43a5c src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java 9eaac43 test/org/waveprotocol/box/server/waveserver/LocalWaveletContainerImplTest.java 5d3f9f6 test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java 3a2ae13 test/org/waveprotocol/box/server/waveserver/WaveMapTest.java eaf4a31 test/org/waveprotocol/box/server/waveserver/WaveServerTest.java 3818794 test/org/waveprotocol/box/server/waveserver/WaveletContainerTest.java cd5b92e Diff: https://reviews.apache.org/r/4924/diff Testing ------- Tests pass, WIAB instance seems to work correctly. Thanks, Yuri
