-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3294/
-----------------------------------------------------------
(Updated June 23, 2012, 1:23 p.m.)
Review request for wave and Yuri Zelikov.
Changes
-------
Here is a new improved patch, hence I am re-opening it.
It now:
- makes use of DocHelper.getText rather than fetching the nodes manually
- better handles spaces at end of links
- clears existing annotations before adding a new one
Generally operates better.
Thoughts?
Description
-------
Implements an auto-linker feature as requested.
This implementation works by splitting the data by the uri seperator "://" and
then attempting to match the scheme to a known (currently hard-coded list) of
schemes. The end is detected by either a space or EOL.
This implementation allows any character to be before a valid scheme, but
relies upon a space or EOL to find the end.
This addresses bug WAVE-275.
https://issues.apache.org/jira/browse/WAVE-275
Diffs (updated)
-----
/src/org/waveprotocol/wave/client/StageThree.java 1351381
/src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java 1351381
/src/org/waveprotocol/wave/client/doodad/link/Link.java 1351381
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java PRE-CREATION
Diff: https://reviews.apache.org/r/3294/diff/
Testing
-------
Tested manually by running the server and typing in URLs in various forms, as
well as by copy-pasting in.
Thanks,
Ali Lown
